studio/cunningham
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

💄(react) homogenize form fields colors

Browse Source 
Based on the QA feedbacks we figured out that form fields were not all
using the exact same greyscale colors.
This commit is contained in:
Nathan Vasse
2023-09-06 16:19:36 +02:00
committed by NathanVss
parent 4c64cb3993
commit 1c45b93a85
21 changed files with 76 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/react/src/components/Forms/DatePicker/DatePicker.tsx
View File

@@ -77,6 +77,7 @@ export const DatePicker = (props: DatePickerProps) => {
label: props.label,
labelAsPlaceholder,
onFocusChange: setIsFocused,
disabled: props.disabled,
}}
/>
</DatePickerAux>

2
packages/react/src/components/Forms/DatePicker/DateRangePicker.tsx
View File

@@ -96,6 +96,7 @@ export const DateRangePicker = ({
label: startLabel,
labelAsPlaceholder,
onFocusChange: setIsFocused,
disabled: props.disabled,
}}
/>
<div className="c__date-picker__range__separator" />
@@ -105,6 +106,7 @@ export const DateRangePicker = ({
label: endLabel,
labelAsPlaceholder,
onFocusChange: setIsFocused,
disabled: props.disabled,
}}
/>
</DatePickerAux>

3
packages/react/src/components/Forms/DatePicker/index.mdx
View File

@@ -168,7 +168,8 @@ Here are the custom design tokens defined by the datepicker.
| border-width | Border width of the datepicker |
| border-radius--hover | Border radius of the datepicker on mouse hover |
| border-radius--focus | Border radius of the datepicker when focused |
| color | Value color |
| value-color | Value color |
| value-color--disabled | Value color when disabled |
| font-size | Value font size |
| height | Height of the combo box |
| item-background-color--hover | Background color of the item on mouse hover (months/years menus) |

15
packages/react/src/components/Forms/DatePicker/index.scss
View File

@@ -11,11 +11,9 @@
border-color: var(--c--components--forms-datepicker--border-color);
border-style: var(--c--components--forms-datepicker--border-style);
display: flex;
transition: border var(--c--theme--transitions--duration) var(--c--theme--transitions--ease-out);
padding: 0 0.75rem;
gap: 1rem;
color: var(--c--components--forms-datepicker--color);
box-sizing: border-box;
height: var(--c--components--forms-datepicker--height);
background-color: var(--c--components--forms-datepicker--background-color);
@@ -63,6 +61,7 @@
&__value {
display: flex;
font-size: var(--c--components--forms-datepicker--font-size);
color: var(--c--components--forms-datepicker--value-color);
overflow: hidden;
flex-grow: 1;
@@ -99,23 +98,23 @@
&--disabled {
.c__date-picker__wrapper {
color: var(--c--theme--colors--greyscale-600);
border-color: var(--c--theme--colors--greyscale-300);
border-color: var(--c--components--forms-datepicker--border-color--disabled);
cursor: default;
pointer-events: none;
label {
color: var(--c--theme--colors--greyscale-400);
}
&__toggle {
color: var(--c--theme--colors--greyscale-400);
}
.c__date-picker__inner {
color: var(--c--theme--colors--greyscale-600);
&__action {
color: var(--c--theme--colors--greyscale-400);
}
&__value {
color: var(--c--components--forms-datepicker--value-color--disabled);
}
}
label {

4
packages/react/src/components/Forms/DatePicker/tokens.ts
View File

@@ -2,6 +2,7 @@ import { DefaultTokens } from "@openfun/cunningham-tokens";
export const tokens = (defaults: DefaultTokens) => ({
"border-color": defaults.theme.colors["greyscale-300"],
"border-color--disabled": defaults.theme.colors["greyscale-200"],
"border-color--focus": defaults.theme.colors["primary-600"],
"border-color--hover": defaults.theme.colors["greyscale-500"],
"border-radius": "8px",
@@ -9,7 +10,8 @@ export const tokens = (defaults: DefaultTokens) => ({
"border-radius--hover": "2px",
"border-style": "solid",
"border-width": "1px",
color: defaults.theme.colors["greyscale-800"],
"value-color": defaults.theme.colors["greyscale-900"],
"value-color--disabled": defaults.theme.colors["greyscale-800"],
"font-size": defaults.theme.font.sizes.l,
height: "3.5rem",
"item-background-color--hover": defaults.theme.colors["greyscale-200"],