From 3e1cdbe9d6d6adbc8cd8e208210fe49d30c1da9e Mon Sep 17 00:00:00 2001 From: Romain Le Cellier Date: Thu, 10 Aug 2023 18:07:28 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=91=EF=B8=8F(react)=20fix=20unexisting?= =?UTF-8?q?=20import?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since b72d0d5c9098e69cc670c9cc3282f2d4d0be01a9 InputRefType doesn't exist. We missed some usage of it that are removed in this fix. --- .changeset/purple-jars-turn.md | 5 +++++ packages/react/src/components/Forms/FileUploader/index.tsx | 3 +-- packages/react/src/components/Forms/Input/index.spec.tsx | 6 +++--- packages/react/src/components/Forms/Input/index.stories.tsx | 4 ++-- 4 files changed, 11 insertions(+), 7 deletions(-) create mode 100644 .changeset/purple-jars-turn.md diff --git a/.changeset/purple-jars-turn.md b/.changeset/purple-jars-turn.md new file mode 100644 index 0000000..d2beb83 --- /dev/null +++ b/.changeset/purple-jars-turn.md @@ -0,0 +1,5 @@ +--- +"@openfun/cunningham-react": minor +--- + +bug fix, remove usage of InputRefType diff --git a/packages/react/src/components/Forms/FileUploader/index.tsx b/packages/react/src/components/Forms/FileUploader/index.tsx index a505cd9..0cdb102 100644 --- a/packages/react/src/components/Forms/FileUploader/index.tsx +++ b/packages/react/src/components/Forms/FileUploader/index.tsx @@ -1,6 +1,5 @@ import React, { forwardRef, InputHTMLAttributes, ReactElement } from "react"; import { Field, FieldProps, FieldState } from ":/components/Forms/Field"; -import { InputRefType } from ":/components/Forms/Input"; import { FileUploaderMulti } from ":/components/Forms/FileUploader/FileUploaderMulti"; import { FileUploaderMono } from ":/components/Forms/FileUploader/FileUploaderMono"; @@ -22,7 +21,7 @@ export interface FileUploaderProps fakeDefaultFiles?: File[]; } -export interface FileUploaderRefType extends InputRefType { +export interface FileUploaderRefType { reset: () => void; } diff --git a/packages/react/src/components/Forms/Input/index.spec.tsx b/packages/react/src/components/Forms/Input/index.spec.tsx index b26264c..3b20025 100644 --- a/packages/react/src/components/Forms/Input/index.spec.tsx +++ b/packages/react/src/components/Forms/Input/index.spec.tsx @@ -2,7 +2,7 @@ import { render, screen, waitFor } from "@testing-library/react"; import React, { useRef } from "react"; import userEvent from "@testing-library/user-event"; import { expect } from "vitest"; -import { Input, InputRefType } from ":/components/Forms/Input/index"; +import { Input } from ":/components/Forms/Input/index"; import { Button } from ":/components/Button"; describe("", () => { @@ -146,11 +146,11 @@ describe("", () => { it("forwards ref", async () => { const user = userEvent.setup(); const Wrapper = () => { - const ref = useRef(null); + const ref = useRef(null); return (
- +
); }; diff --git a/packages/react/src/components/Forms/Input/index.stories.tsx b/packages/react/src/components/Forms/Input/index.stories.tsx index 42924e3..78a07bc 100644 --- a/packages/react/src/components/Forms/Input/index.stories.tsx +++ b/packages/react/src/components/Forms/Input/index.stories.tsx @@ -3,7 +3,7 @@ import { Meta } from "@storybook/react"; import { useForm } from "react-hook-form"; import * as Yup from "yup"; import React, { useRef } from "react"; -import { Input, InputRefType } from ":/components/Forms/Input/index"; +import { Input } from ":/components/Forms/Input/index"; import { Button } from ":/components/Button"; import { getFieldState, @@ -166,7 +166,7 @@ export const NonControlled = () => { }; export const WithRef = () => { - const ref = useRef(null); + const ref = useRef(null); return (