From 424fa05cca19faf39de2c8cbfa68c6437f1954d4 Mon Sep 17 00:00:00 2001 From: Nathan Vasse Date: Fri, 12 May 2023 16:58:51 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A7(react)=20migrate=20storybook=20dep?= =?UTF-8?q?loyment=20to=20version=207?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The package @storybook/storybook-deployer that seems to not directly work with Storybook 7 was expecting that command named "build-storybook" to exist. With the bin updates of Storybook 7 this bin does not longer exist, so I created a specfic script inside package.json that is named "build-storybook" too in order to make everything work. Also now that Storybook uses directly the local vite config, the fact that our config generates types was causing issues when building Storybook, that why we filter plugins in main.ts in order to remove "vite:dts". --- packages/react/.storybook/main.ts | 13 +++++++++++++ packages/react/package.json | 1 + 2 files changed, 14 insertions(+) diff --git a/packages/react/.storybook/main.ts b/packages/react/.storybook/main.ts index a84350a..ed20f27 100644 --- a/packages/react/.storybook/main.ts +++ b/packages/react/.storybook/main.ts @@ -28,6 +28,19 @@ const config: StorybookConfig = { features: { storyStoreV7: true, }, + async viteFinal(config, options) { + // We don't want the Storybook build to generate type definitions. + const newConfig = { + ...config, + plugins: config.plugins.filter((plugin) => { + if (typeof plugin === "object") { + return (plugin as any).name !== "vite:dts"; + } + return true; + }), + }; + return newConfig; + }, }; export default config; diff --git a/packages/react/package.json b/packages/react/package.json index 32fe850..3d547bb 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -35,6 +35,7 @@ "test-watch": "vitest", "coverage": "vitest run --coverage", "storybook": "storybook dev -p 6006", + "build-storybook": "storybook build", "deploy-storybook": "storybook-to-ghpages" }, "dependencies": {