From 859a75cebeaf25aedab836063ef3d8d87a01300e Mon Sep 17 00:00:00 2001 From: Romain Le Cellier Date: Fri, 22 Sep 2023 15:18:21 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=A9=B9(frontend)=20fix=20react=20userEffe?= =?UTF-8?q?ct?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit in Select/mono-simple The whole downshiftProps object change every time a update is made on it. By observing only initialSelectedItem prop, we reduce the amount of call of this useEffect. --- packages/react/src/components/Forms/Select/mono-simple.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/components/Forms/Select/mono-simple.tsx b/packages/react/src/components/Forms/Select/mono-simple.tsx index 65cdbdc..870f63d 100644 --- a/packages/react/src/components/Forms/Select/mono-simple.tsx +++ b/packages/react/src/components/Forms/Select/mono-simple.tsx @@ -30,7 +30,7 @@ export const SelectMonoSimple = (props: SubProps) => { } downshiftReturn.selectItem(optionToSelect ?? null); - }, [props.value, props.options]); + }, [props.value, props.downshiftProps.initialSelectedItem]); return (