From 8cda41772df1cfe3fc553447bff8e46b02e0f780 Mon Sep 17 00:00:00 2001 From: Nathan Vasse Date: Mon, 22 May 2023 11:39:11 +0200 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F(react)=20fix=20Storybook=20s?= =?UTF-8?q?ource=20blocks?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Due to the recent upgrade to Storybook 7, the source blocks of Canvases were broken, they were only showing args. This was mainly due to the fact that as of Storybook 7 the meta tags of the MDX files have changed, thus causing the issue. These are now based on imports. We also needed to rename index.stories.mdx files to index.mdx because Storybook was throwing errors, maybe due to a conflicts with index.stories.tsx files and new imports. Anyway this way of naming MDX files seems to be the recommend one based on the official documentation. --- .changeset/fast-bulldogs-cross.md | 5 +++ packages/react/.storybook/main.ts | 2 +- .../Button/{index.stories.mdx => index.mdx} | 5 ++- .../src/components/Button/index.stories.tsx | 32 +++++++++---------- .../DataGrid/{index.stories.mdx => index.mdx} | 5 ++- .../Checkbox/{index.stories.mdx => index.mdx} | 4 +-- .../Field/{index.stories.mdx => index.mdx} | 5 ++- .../Input/{index.stories.mdx => index.mdx} | 5 ++- .../Radio/{index.stories.mdx => index.mdx} | 3 +- .../Select/{index.stories.mdx => index.mdx} | 5 ++- .../{index.stories.mdx => index.mdx} | 3 +- 11 files changed, 37 insertions(+), 37 deletions(-) create mode 100644 .changeset/fast-bulldogs-cross.md rename packages/react/src/components/Button/{index.stories.mdx => index.mdx} (96%) rename packages/react/src/components/DataGrid/{index.stories.mdx => index.mdx} (98%) rename packages/react/src/components/Forms/Checkbox/{index.stories.mdx => index.mdx} (96%) rename packages/react/src/components/Forms/Field/{index.stories.mdx => index.mdx} (88%) rename packages/react/src/components/Forms/Input/{index.stories.mdx => index.mdx} (97%) rename packages/react/src/components/Forms/Radio/{index.stories.mdx => index.mdx} (97%) rename packages/react/src/components/Forms/Select/{index.stories.mdx => index.mdx} (97%) rename packages/react/src/components/Pagination/{index.stories.mdx => index.mdx} (96%) diff --git a/.changeset/fast-bulldogs-cross.md b/.changeset/fast-bulldogs-cross.md new file mode 100644 index 0000000..9e26032 --- /dev/null +++ b/.changeset/fast-bulldogs-cross.md @@ -0,0 +1,5 @@ +--- +"@openfun/cunningham-react": patch +--- + +fix Storybook source blocks diff --git a/packages/react/.storybook/main.ts b/packages/react/.storybook/main.ts index ed20f27..b16ffcb 100644 --- a/packages/react/.storybook/main.ts +++ b/packages/react/.storybook/main.ts @@ -2,7 +2,7 @@ import { StorybookConfig } from "@storybook/react-vite"; import remarkGfm from "remark-gfm"; const config: StorybookConfig = { - stories: ["../src/**/*.stories.mdx", "../src/**/*.stories.@(js|jsx|ts|tsx)"], + stories: ["../src/**/*.mdx", "../src/**/*.stories.@(js|jsx|ts|tsx)"], addons: [ "@storybook/addon-links", "@storybook/addon-essentials", diff --git a/packages/react/src/components/Button/index.stories.mdx b/packages/react/src/components/Button/index.mdx similarity index 96% rename from packages/react/src/components/Button/index.stories.mdx rename to packages/react/src/components/Button/index.mdx index a709ca6..b96f4d8 100644 --- a/packages/react/src/components/Button/index.stories.mdx +++ b/packages/react/src/components/Button/index.mdx @@ -1,9 +1,8 @@ import { Canvas, Meta, Story, Source, ArgsTable } from '@storybook/addon-docs'; import { Button } from "./index"; +import * as Stories from './index.stories'; - - -export const Template = (args) =>