From 98c7075637eb01268bd457a5849626957da50f2b Mon Sep 17 00:00:00 2001 From: Nathan Vasse Date: Mon, 20 Nov 2023 17:12:58 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A7(Docker)=20upgrade=20to=20node=2018?= =?UTF-8?q?.18?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The node LTS version is 18 and node 16 has reached its end of support the 11th september 2023. Furthermore, some JS packages starts to remove support of node version less than 18. That's why it seems to be the right moment for us to level up to node 18.18. --- .circleci/config.yml | 10 +++++----- docker-compose.yml | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3d03814..860b6f8 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -49,7 +49,7 @@ jobs: # ---- Codebase ----- build: docker: - - image: cimg/node:16.18 + - image: cimg/node:18.18 working_directory: ~/cunningham steps: - *checkout_cunningham @@ -81,7 +81,7 @@ jobs: key: v1-front-dependencies-{{ checksum "yarn.lock" }} lint: docker: - - image: cimg/node:16.18 + - image: cimg/node:18.18 working_directory: ~/cunningham steps: - *checkout_cunningham @@ -92,7 +92,7 @@ jobs: test: docker: - - image: cimg/node:16.18 + - image: cimg/node:18.18 parallelism: 4 resource_class: large working_directory: ~/cunningham @@ -122,7 +122,7 @@ jobs: # ---- Deploy ---- publish-storybook: docker: - - image: cimg/node:16.18 + - image: cimg/node:18.18 working_directory: ~/cunningham steps: - add_ssh_keys: @@ -141,7 +141,7 @@ jobs: yarn deploy-storybook publish-packages: docker: - - image: cimg/node:16.15 + - image: cimg/node:18.18 auth: username: $DOCKER_USER password: $DOCKER_PASS diff --git a/docker-compose.yml b/docker-compose.yml index 348c79e..45d4cb8 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -2,7 +2,7 @@ version: "3.5" services: node: - image: node:16.15 + image: node:18.18 working_dir: /app user: "${DOCKER_USER:-1000}" ports: