From cef284b6ab6853bfa08203dcc60616276cb4c50e Mon Sep 17 00:00:00 2001 From: Nathan Vasse Date: Fri, 5 Jan 2024 17:06:08 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=92=84(react)=20update=20Alert=20and=20To?= =?UTF-8?q?ast=20icons?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For aesthetic reasons we decided to use the circled versions of icons. --- packages/react/src/components/Alert/Utils.tsx | 4 ++-- packages/react/src/components/Alert/index.spec.tsx | 4 ++-- packages/react/src/components/Toast/index.spec.tsx | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/react/src/components/Alert/Utils.tsx b/packages/react/src/components/Alert/Utils.tsx index 19d6a8d..044e4aa 100644 --- a/packages/react/src/components/Alert/Utils.tsx +++ b/packages/react/src/components/Alert/Utils.tsx @@ -27,9 +27,9 @@ export const iconFromType = (type?: AlertType | ToastType) => { case AlertType.INFO: return "info"; case AlertType.SUCCESS: - return "task_alt"; + return "check_circle"; case AlertType.WARNING: - return "warning"; + return "error_outline"; case AlertType.ERROR: return "cancel"; default: diff --git a/packages/react/src/components/Alert/index.spec.tsx b/packages/react/src/components/Alert/index.spec.tsx index b4508e9..3b1531a 100644 --- a/packages/react/src/components/Alert/index.spec.tsx +++ b/packages/react/src/components/Alert/index.spec.tsx @@ -8,8 +8,8 @@ import { CunninghamProvider } from ":/components/Provider"; describe("", () => { it.each([ [AlertType.INFO, "info"], - [AlertType.SUCCESS, "task_alt"], - [AlertType.WARNING, "warning"], + [AlertType.SUCCESS, "check_circle"], + [AlertType.WARNING, "error_outline"], [AlertType.ERROR, "cancel"], [AlertType.NEUTRAL, undefined], ])("renders % alert with according icon", (type, icon) => { diff --git a/packages/react/src/components/Toast/index.spec.tsx b/packages/react/src/components/Toast/index.spec.tsx index 8224e30..41724b2 100644 --- a/packages/react/src/components/Toast/index.spec.tsx +++ b/packages/react/src/components/Toast/index.spec.tsx @@ -124,8 +124,8 @@ describe("", () => { it.each([ [ToastType.INFO, "info"], - [ToastType.SUCCESS, "task_alt"], - [ToastType.WARNING, "warning"], + [ToastType.SUCCESS, "check_circle"], + [ToastType.WARNING, "error_outline"], [ToastType.ERROR, "cancel"], [ToastType.NEUTRAL, undefined], ])("shows a %s toast", async (type, iconName) => {