From d506cab978204028c1f2bf7de183a94791cff29d Mon Sep 17 00:00:00 2001
From: Romain Le Cellier <rlecellier@gmail.com>
Date: Wed, 26 Jul 2023 16:52:49 +0200
Subject: [PATCH] =?UTF-8?q?=E2=9C=A8(react)=20react-hook-form=20Checkbox?=
 =?UTF-8?q?=20example?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Our form elements needs to be usable with react-hook-form
---
 .../src/components/Forms/Checkbox/index.mdx   |   9 ++
 .../Forms/Checkbox/index.stories.tsx          |  54 ++++++++-
 .../src/components/Forms/Checkbox/index.tsx   | 104 ++++++++++--------
 3 files changed, 121 insertions(+), 46 deletions(-)

diff --git a/packages/react/src/components/Forms/Checkbox/index.mdx b/packages/react/src/components/Forms/Checkbox/index.mdx
index 71c01b5..cba0811 100644
--- a/packages/react/src/components/Forms/Checkbox/index.mdx
+++ b/packages/react/src/components/Forms/Checkbox/index.mdx
@@ -85,6 +85,15 @@ You can also define `state`, `text` props on the group component
   <Story id="components-forms-checkbox--group-success"/>
 </Canvas>
 
+## Usage with react-hook-form
+
+You can use this input with [react-hook-form](https://react-hook-form.com/docs)
+
+<Canvas sourceState="shown">
+  <Story id="components-forms-checkbox--react-hook-form"/>
+</Canvas>
+
+
 ### Props
 
 <ArgTypes of={Checkbox} />
diff --git a/packages/react/src/components/Forms/Checkbox/index.stories.tsx b/packages/react/src/components/Forms/Checkbox/index.stories.tsx
index cd71562..9170e1c 100644
--- a/packages/react/src/components/Forms/Checkbox/index.stories.tsx
+++ b/packages/react/src/components/Forms/Checkbox/index.stories.tsx
@@ -1,6 +1,15 @@
-import { Meta, StoryFn } from "@storybook/react";
 import React from "react";
+import { yupResolver } from "@hookform/resolvers/yup";
+import { Meta, StoryFn } from "@storybook/react";
+import { useForm } from "react-hook-form";
+import * as Yup from "yup";
 import { Checkbox, CheckboxGroup } from ":/components/Forms/Checkbox/index";
+import { Button } from ":/components/Button";
+import {
+  getFieldState,
+  getFieldErrorMessage,
+  onSubmit,
+} from ":/tests/reactHookFormUtils";
 
 export default {
   title: "Components/Forms/Checkbox",
@@ -138,3 +147,46 @@ export const GroupSuccess = () => (
     </CheckboxGroup>
   </div>
 );
+
+export const ReactHookForm = () => {
+  interface CheckboxExampleFormValues {
+    terms: boolean;
+  }
+
+  const checkboxExampleSchema = Yup.object().shape({
+    terms: Yup.boolean()
+      .required()
+      .oneOf([true], "You have to accept the terms of use"),
+  });
+
+  const { register, handleSubmit, formState } =
+    useForm<CheckboxExampleFormValues>({
+      defaultValues: {
+        terms: false,
+      },
+      mode: "onChange",
+      reValidateMode: "onChange",
+      resolver: yupResolver(checkboxExampleSchema),
+    });
+
+  return (
+    <form
+      style={{
+        display: "flex",
+        flexDirection: "column",
+        gap: "1rem",
+        width: "400px",
+      }}
+      onSubmit={handleSubmit(onSubmit)}
+    >
+      <Checkbox
+        label="I accept the terms of use"
+        fullWidth
+        state={getFieldState("terms", formState)}
+        text={getFieldErrorMessage("terms", formState)}
+        {...register("terms")}
+      />
+      <Button fullWidth={true}>Log-in</Button>
+    </form>
+  );
+};
diff --git a/packages/react/src/components/Forms/Checkbox/index.tsx b/packages/react/src/components/Forms/Checkbox/index.tsx
index 97e669e..b4edaa7 100644
--- a/packages/react/src/components/Forms/Checkbox/index.tsx
+++ b/packages/react/src/components/Forms/Checkbox/index.tsx
@@ -1,6 +1,7 @@
 import React, {
   InputHTMLAttributes,
   PropsWithChildren,
+  forwardRef,
   useEffect,
   useRef,
   useState,
@@ -14,55 +15,68 @@ type Props = InputHTMLAttributes<HTMLInputElement> &
     label?: string;
   };
 
-export const Checkbox = ({
-  indeterminate,
-  className = "",
-  checked,
-  label,
-  text,
-  rightText,
-  state,
-  ...props
-}: Props) => {
-  const inputRef = useRef<HTMLInputElement>(null);
-  const [value, setValue] = useState<boolean>(!!checked);
+export const Checkbox = forwardRef<HTMLInputElement, Props>(
+  (
+    {
+      indeterminate,
+      className = "",
+      checked,
+      label,
+      text,
+      rightText,
+      state,
+      ...props
+    }: Props,
+    ref,
+  ) => {
+    const inputRef = useRef<HTMLInputElement>();
+    const [value, setValue] = useState<boolean>(!!checked);
 
-  useEffect(() => {
-    setValue(!!checked);
-  }, [checked]);
+    useEffect(() => {
+      setValue(!!checked);
+    }, [checked]);
 
-  useEffect(() => {
-    if (inputRef.current) {
-      inputRef.current.indeterminate = !!indeterminate;
-    }
-  }, [indeterminate]);
+    useEffect(() => {
+      if (inputRef.current) {
+        inputRef.current.indeterminate = !!indeterminate;
+      }
+    }, [indeterminate]);
 
-  return (
-    <label
-      className={classNames("c__checkbox", {
-        "c__checkbox--disabled": props.disabled,
-      })}
-    >
-      <Field text={text} rightText={rightText} compact={true} state={state}>
-        <div className="c__checkbox__container">
-          <div className="c__checkbox__wrapper">
-            <input
-              type="checkbox"
-              className={className}
-              onChange={(e) => setValue(e.target.checked)}
-              {...props}
-              checked={value}
-              ref={inputRef}
-            />
-            <Indeterminate />
-            <Checkmark />
+    return (
+      <label
+        className={classNames("c__checkbox", {
+          "c__checkbox--disabled": props.disabled,
+        })}
+      >
+        <Field text={text} rightText={rightText} compact={true} state={state}>
+          <div className="c__checkbox__container">
+            <div className="c__checkbox__wrapper">
+              <input
+                type="checkbox"
+                className={className}
+                {...props}
+                onChange={(e) => {
+                  setValue(e.target.checked);
+                  props.onChange?.(e);
+                }}
+                checked={value}
+                ref={(checkboxRef) => {
+                  if (typeof ref === "function") {
+                    ref(checkboxRef);
+                  }
+                  inputRef.current = checkboxRef || undefined;
+                }}
+              />
+              <Indeterminate />
+              <Checkmark />
+            </div>
+            {label && <div className="c__checkbox__label">{label}</div>}
           </div>
-          {label && <div className="c__checkbox__label">{label}</div>}
-        </div>
-      </Field>
-    </label>
-  );
-};
+        </Field>
+      </label>
+    );
+  },
+);
 
 export const CheckboxGroup = ({
   children,