From e9a85ee63f1c8dec45ed94f712223d9604e9d4e4 Mon Sep 17 00:00:00 2001 From: jbpenrath Date: Mon, 5 May 2025 18:13:30 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(react)=20prevent=20error=20on=20se?= =?UTF-8?q?archable=20select?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When a select is searchable, when the user search term but this one return no items, currently the component raise an error. --- .changeset/social-cougars-glow.md | 5 +++++ .../react/src/components/Forms/Select/multi-searchable.tsx | 2 +- packages/react/src/components/Forms/Select/multi-simple.tsx | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/social-cougars-glow.md diff --git a/.changeset/social-cougars-glow.md b/.changeset/social-cougars-glow.md new file mode 100644 index 0000000..780c208 --- /dev/null +++ b/.changeset/social-cougars-glow.md @@ -0,0 +1,5 @@ +--- +"@openfun/cunningham-react": patch +--- + +prevent error on searchable select diff --git a/packages/react/src/components/Forms/Select/multi-searchable.tsx b/packages/react/src/components/Forms/Select/multi-searchable.tsx index b2b4582..d165ee8 100644 --- a/packages/react/src/components/Forms/Select/multi-searchable.tsx +++ b/packages/react/src/components/Forms/Select/multi-searchable.tsx @@ -76,7 +76,7 @@ export const SelectMultiSearchable = ({ ref, ...props }: SubProps) => { break; } }, - isItemDisabled: (item) => !!item.disabled, + isItemDisabled: (item) => !!item?.disabled, }); const inputProps = downshiftReturn.getInputProps({ diff --git a/packages/react/src/components/Forms/Select/multi-simple.tsx b/packages/react/src/components/Forms/Select/multi-simple.tsx index e48d2aa..0844b3a 100644 --- a/packages/react/src/components/Forms/Select/multi-simple.tsx +++ b/packages/react/src/components/Forms/Select/multi-simple.tsx @@ -88,7 +88,7 @@ export const SelectMultiSimple = ({ ref, ...props }: SubProps) => { break; } }, - isItemDisabled: (item) => !!item.disabled, + isItemDisabled: (item) => !!item?.disabled, }); const toggleRef = useRef(null);