🐛(react) use uniqueId for modal portals
When a ModalProvider is mounted, it renders a div with an id which is use as container to render modals through portals. But currently, if developer use several CunninghamProvider across its application, a container with the same id will be rendered several times that is weird. To prevent this kind of id collision, we decide to generate a unique Id for each ModalProvider. Resolve #352
This commit is contained in:
committed by
Jean-Baptiste PENRATH
parent
5b0d794217
commit
ef8a225406
@@ -58,7 +58,7 @@ export type ModalProps = PropsWithChildren & {
|
||||
export const Modal = (props: ModalProps) => {
|
||||
/**
|
||||
* This is a workaround to prevent the modal from rendering on the first render because if the modal is open on the
|
||||
* first render, it will not be able to resolve document.getElementById("c__modals-portal") which is not rendered yet.
|
||||
* first render, it will not be able to resolve document.getElementById(<MODAL_PARENT_ID>) which is not rendered yet.
|
||||
*/
|
||||
const [firstRender, setFirstRender] = React.useState(true);
|
||||
useEffect(() => {
|
||||
|
||||
Reference in New Issue
Block a user