From fe5daa918f8dc9317a4f0fcca808a55603f6926d Mon Sep 17 00:00:00 2001 From: Nathan Vasse Date: Wed, 27 Sep 2023 17:27:02 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=8C(deps)=20set=20@testing-library/dom?= =?UTF-8?q?=20as=20resolution?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The renovate PR made the tests fail due to lots of new warnings. This kind of warning: update not wrapped inside act ... They were mainly throwed from user event API calls, but internally this library already calls act() so it is not supposed to happen. In reality it happen when different versions of @testing-library/dom are used by the framework wrapper and the main one loaded by our project. See https://github.com/testing-library/user-event/discussions/906 --- package.json | 3 +++ yarn.lock | 16 +--------------- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/package.json b/package.json index 3b45f7e..d7ca0d4 100644 --- a/package.json +++ b/package.json @@ -28,6 +28,9 @@ "@changesets/cli": "2.26.2" }, "packageManager": "yarn@1.22.19", + "resolutions": { + "@testing-library/dom": "9.3.3" + }, "volta": { "node": "18.18.0", "yarn": "1.22.19" diff --git a/yarn.lock b/yarn.lock index 3629cd0..0019aa1 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5371,7 +5371,7 @@ resolved "https://registry.yarnpkg.com/@tanstack/table-core/-/table-core-8.10.3.tgz#7f7a0753645e05bb15c97512785abbae7b626ee3" integrity sha512-hJ55YfJlWbfzRROfcyA/kC1aZr/shsLA8XNAwN8jXylhYWGLnPmiJJISrUfj4dMMWRiFi0xBlnlC7MLH+zSrcw== -"@testing-library/dom@9.3.3": +"@testing-library/dom@9.3.3", "@testing-library/dom@^9.0.0": version "9.3.3" resolved "https://registry.yarnpkg.com/@testing-library/dom/-/dom-9.3.3.tgz#108c23a5b0ef51121c26ae92eb3179416b0434f5" integrity sha512-fB0R+fa3AUqbLHWyxXa2kGVtf1Fe1ZZFr0Zp6AIbIAzXb2mKbEXl+PCQNUOaq5lbTab5tfctfXRNsWXxa2f7Aw== @@ -5385,20 +5385,6 @@ lz-string "^1.5.0" pretty-format "^27.0.2" -"@testing-library/dom@^9.0.0": - version "9.3.1" - resolved "https://registry.yarnpkg.com/@testing-library/dom/-/dom-9.3.1.tgz#8094f560e9389fb973fe957af41bf766937a9ee9" - integrity sha512-0DGPd9AR3+iDTjGoMpxIkAsUihHZ3Ai6CneU6bRRrffXMgzCdlNk43jTrD2/5LT6CBb3MWTP8v510JzYtahD2w== - dependencies: - "@babel/code-frame" "^7.10.4" - "@babel/runtime" "^7.12.5" - "@types/aria-query" "^5.0.1" - aria-query "5.1.3" - chalk "^4.1.0" - dom-accessibility-api "^0.5.9" - lz-string "^1.5.0" - pretty-format "^27.0.2" - "@testing-library/jest-dom@6.1.3": version "6.1.3" resolved "https://registry.yarnpkg.com/@testing-library/jest-dom/-/jest-dom-6.1.3.tgz#443118c9e4043f96396f120de2c7122504a079c5"