Commit Graph

568 Commits

Author SHA1 Message Date
Nathan Vasse
974f139f14 🐛(react) add warning when onSortModelChange is missing
We encountered the case were a user reported that the column were
making cursor pointer but clicking on it was doing nothing. It was
caused by the fact that onSortModelChange was not provided. So in
this case we trigger a warning only if enableSorting is true on one
column at least.
2024-03-12 11:34:20 +01:00
Nathan Vasse
317cab4bad (react) add sorting on custom cells
Previously sorting on custom cells was not possible because they were
considered as "display cells" by React-Table, which is made for actions
columns, which aren't sortable.

Closes #296 #100
2024-03-12 11:34:20 +01:00
renovate[bot]
91a7b2369f ⬆️(dependencies) update js dependencies 2024-03-11 16:29:45 +01:00
Nathan Vasse
30ec253ab0 (react) make Pagination goto input optionnal
Based on a recent request we needed to make it optionnal in order to
have simpler pagination in some cases.

Closes #183
2024-03-08 16:33:54 +01:00
Nathan Vasse
d63c203b21 🚨(react) fix CSS end warning usage
Next.js is warning about the usage of end instead of flex-end during
compilation.

Fixes #291
2024-03-08 15:06:25 +01:00
Nathan Vasse
31fa91e92f (react) add empty placeholder customization props
We want to be able to customize the empty placeholder label, add a
call to action and choose whether we want to display the image as well.

Closes #27
2024-03-06 17:43:29 +01:00
Nathan Vasse
c667d51a11 🔖(release) version packages
Bump @openfun/cunningham-tokens to 2.1.1
Bump @openfun/cunningham-react to 2.6.0
2024-03-04 15:50:15 +01:00
Nathan Vasse
04ab3306e2 (react) add onSearchInputChange callback to searchable select
We want to be able to notify an event when the search term of the
searchable select gets updated.
2024-03-04 14:40:40 +01:00
Nathan Vasse
680365a117 💄(react) make Modal close button sticky
We want to make sure this button is always visible inside scrollable
modals.

Fixes #278
2024-02-28 17:36:32 +01:00
Nathan Vasse
c5e5d9fa85 📝(react) make color prop of Button appear in the doc
This prop color was not appearing in the ArgTypes because it was an override
attribute.

Fixes #235
2024-02-28 17:31:02 +01:00
Nathan Vasse
ce7a3d7c5b 📱(react) improve Modal responsive
The footer of the Modal component was not perfect on mobile, the sided
footer must be on two lines on mobile.
2024-02-28 17:19:32 +01:00
Nathan Vasse
1707ad0b66 📱(demo) make demo responsive
The responsive version of the demo app was buggy, so we need to
make it shiny!

Fixes #275
2024-02-28 17:19:32 +01:00
Nathan Vasse
4fbd75cdcf 🐛(tokens) fix invalid sass with comma
The generated sass from tokens containing commas, like font families was
not valid due to the way maps are made in sass. So we wrap those value
in quotes.
2024-02-28 17:19:32 +01:00
Nathan Vasse
7461626822 📱(react) improve DateRangerPicker responsive
The component was not able to resize properly on narrow screens.
2024-02-28 17:19:32 +01:00
Nathan Vasse
54df5d6c71 💄(react) remove modal content outline on focus
This was giving a strange look n feel, neither improving a11y.
2024-02-28 17:19:32 +01:00
Nathan Vasse
6d1da169e7 ♻️(react) prevent animate usage on some envs
This animate function is not supported by some testing environments,
to prevent any crashes on consumers side we need to first make sure
this function is defined.

Fixes #281
2024-02-28 10:51:47 +01:00
Nathan Vasse
ea39ea09fd 🔖(release) version packages
Bump @openfun/cunningham-react to 2.5.0
Bump cunningham-demo to 2.0.0
2024-02-21 16:43:45 +01:00
Nathan Vasse
a17c805f50 🐛(react) fix closeOnClickOutside not working
Our recent changes to enable the customization of the modal backdrop
caused this prop to not work anymore.
2024-02-21 16:08:23 +01:00
Nathan Vasse
3ef7744083 ♻️(demo) refactor Onboarding modal display
Here is a shorter way to achieve the same result as before.
2024-02-21 14:54:52 +01:00
Nathan Vasse
7f12f4d9b0 🐛(fix) fix body scroll when a modal is opened
It was possible to scroll the body when a modal is opened, it was
cutting the visibility of the modal, and was simply weird.

Fixes #263
2024-02-21 14:54:52 +01:00
Nathan Vasse
e9956829d1 ♻️(demo) remove ready flag
This workaround was used as a workaround because default opened modals
were causing a crash. See #269
2024-02-20 17:21:32 +01:00
Nathan Vasse
266701a733 🐛(react) fix default opened modal
Modal with isOpen=true on first render were causing a crash. With
this approach we make sure the portal node is already rendered.

Fixes #259
2024-02-20 17:21:32 +01:00
renovate[bot]
95a6d6dec7 ⬆️(dependencies) update js dependencies 2024-02-19 17:24:21 +01:00
Nathan Vasse
10c9abf1d2 (demo) add delete confirmation modal
We want to showcase pre built modals in the demo.
2024-02-19 16:48:39 +01:00
Nathan Vasse
f81005f66c 🏷️(react) export ModalProvider to package
We were not able to import useModals from consumer code. It was
preventing us to use pre built modals.

Fixes #262
2024-02-19 16:48:39 +01:00
Nathan Vasse
c3416f3113 🏷️(react) modal title type
We need to be able to use any ReactNode a modal title.

Fixes #260
2024-02-19 15:39:03 +01:00
Nathan Vasse
670eb8ce57 🏷️(react) remove ModalFooter export
This component was not supposed to be exported, it could be misleading
for consumers.

Fixes #258
2024-02-19 15:30:39 +01:00
jbpenrath
1adff4a165 💄(demo) fix layout issue
The previous fix introduces a new layout issue. Let's fix that properly.
..
2024-02-15 18:04:48 +01:00
jbpenrath
ea74307b9b 💄(demo) fix asset path and layout issue
Asset paths were wrong so once built the application contained broken
links. Then fix a layout issue.
2024-02-15 17:23:40 +01:00
jbpenrath
ec4fbb082c 💄(demo) improve some default style
Improve typography responsive and customize card design tokens for the
dark theme
2024-02-15 17:05:06 +01:00
jbpenrath
d119b79c3f (demo) add a footer
Add a footer to display some useful links
2024-02-15 17:05:06 +01:00
jbpenrath
bacd9446b4 (demo) add onboarding modal
On first visit, display an onboarding modal to explain the purpose of
this demo.
2024-02-15 17:05:06 +01:00
jbpenrath
86138df8fe (demo) use modal to show create form
Now that we have a modal component, let's use it to display our creation
 form.
2024-02-15 17:05:06 +01:00
jbpenrath
7913075faf 🍱(demo) change favicon application
Change favicon and title
2024-02-15 17:05:06 +01:00
jbpenrath
ca56ab32c7 💄(demo) add blueney theme
Add a dark theme inspired by another famous streaming platform with blue
 tint.
2024-02-15 17:05:06 +01:00
jbpenrath
270357bc7e 💄(demo) add reflux theme
Add a dark theme inspired by a famous streaming platform
with red tint.
2024-02-15 17:05:06 +01:00
jbpenrath
cd476ae82b (demo) improve create form submit
Take in account more fields. Use a form instead a ref to retrieve values
 easily.
2024-02-15 17:05:06 +01:00
jbpenrath
7320671589 💬(demo) transform gender form into sex
To stick to civil information we rename gender field to sex.
2024-02-15 17:05:06 +01:00
jbpenrath
0ade12251e (demo) add theme selector
As we aims to create several themes for this demo app, we add a select
to easily switch between all existing themes.
2024-02-15 17:05:06 +01:00
jbpenrath
be1e2e2614 💄(react) make modal backdrop color customisable
As we cannot user CSS vars into backdrop pseudo element, we decide to
create a dom element to simulate the modal backdrop.

Resolve #257
2024-02-15 14:54:17 +01:00
Nathan Vasse
fac203314f 📝(readme) add demo link to main README
As we deploy the demo site on gh-pages we now want to provide a link
on the main README.
2024-02-15 14:44:17 +01:00
Nathan Vasse
a044367d41 👷(ci) deploy demo app on gh-pages
We want to provide a public access to our demo app.
2024-02-15 14:44:17 +01:00
Nathan Vasse
c815c4234b 📝(doc) fix new storybook doc url
In the previous PR we forgot to update all the URLs.
2024-02-14 17:31:31 +01:00
Nathan Vasse
def859ee0b 👷(ci) put storybook build in a gh-pages sub folder
Our main goal doing this is to allow us to have multiple static build
standing next to each other on our gh-pages.
2024-02-14 15:47:44 +01:00
Lebaud Antoine
9795b7184b 🩹(react) fix DateRangePicker layout overflow
Resolved a width conflict in the date range picker where the field width
conflicted with the component's min-width. This caused content
overflow in the field container, resulting in layout issues.
2024-02-14 10:39:34 +01:00
Nathan Vasse
f685abb36c ♻️(react) use info design tokens
Some info variant of components were using primary design token instead
of info.
2024-02-13 15:14:05 +01:00
Nathan Vasse
162809dd9c ♻️(react) remove disabled from getItemProps
This way triggering thousands of warnings in the console and during tests.
Removing it works because it seems that having item.disabled set allows
to not having to use isItemDisabled.
2024-02-13 10:36:14 +01:00
Nathan Vasse
ebfccc1f99 🐛(react) fix DatePicker dropdowns
When having a start date, using the year or month dropdown was
causing the calendar to abruptly close.

Fixes #244
2024-02-13 10:36:14 +01:00
Nathan Vasse
b0eff283a1 📝(react) enhance Application demo form
This form was not using multi select, adding it provides a way to
easily interact with all the form component in a single form making
sure they all work.
2024-02-12 11:46:09 +01:00
Nathan Vasse
f16eed9a6d 🐛(react) fix Select submit button
As the default type of button is "submit", when including a Select
inside a form, clicking on any of its button was triggering form
submission.
2024-02-12 11:46:09 +01:00