From 03953f0fe77520975adf89f90c30b0ebd0a96cd3 Mon Sep 17 00:00:00 2001
From: Anthony LC <anthony.le-courric@mail.numerique.gouv.fr>
Date: Fri, 5 Jul 2024 14:16:06 +0200
Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=EF=B8=8F(frontend)=20use=20resetQueri?=
 =?UTF-8?q?es=20instead=20of=20invalidateQueries?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

With the list of documents, invalidateQueries doesn't
refresh as expected the list of documents. We
will prefer resetQueries, it seems to be more
appropriate for this case.
---
 .../src/features/docs/doc-management/api/useCreateDoc.tsx  | 7 +++++--
 .../src/features/docs/doc-management/api/useDocs.tsx       | 3 ++-
 .../src/features/docs/doc-management/api/useRemoveDoc.tsx  | 2 +-
 .../src/features/docs/doc-management/api/useUpdateDoc.tsx  | 2 +-
 .../docs/members/members-add/api/useCreateDocAccess.tsx    | 2 +-
 .../docs/members/members-grid/api/useDeleteDocAccess.ts    | 2 +-
 6 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/src/frontend/apps/impress/src/features/docs/doc-management/api/useCreateDoc.tsx b/src/frontend/apps/impress/src/features/docs/doc-management/api/useCreateDoc.tsx
index e7d2363f..f0a5b3f9 100644
--- a/src/frontend/apps/impress/src/features/docs/doc-management/api/useCreateDoc.tsx
+++ b/src/frontend/apps/impress/src/features/docs/doc-management/api/useCreateDoc.tsx
@@ -1,7 +1,10 @@
 import { useMutation, useQueryClient } from '@tanstack/react-query';
 
 import { APIError, errorCauses, fetchAPI } from '@/api';
-import { Doc, KEY_LIST_DOC } from '@/features/docs';
+
+import { Doc } from '../types';
+
+import { KEY_LIST_DOC } from './useDocs';
 
 type CreateDocParam = Pick<Doc, 'title' | 'is_public'>;
 
@@ -33,7 +36,7 @@ export function useCreateDoc({ onSuccess }: CreateDocProps) {
   return useMutation<Doc, APIError, CreateDocParam>({
     mutationFn: createDoc,
     onSuccess: (data) => {
-      void queryClient.invalidateQueries({
+      void queryClient.resetQueries({
         queryKey: [KEY_LIST_DOC],
       });
       onSuccess(data);
diff --git a/src/frontend/apps/impress/src/features/docs/doc-management/api/useDocs.tsx b/src/frontend/apps/impress/src/features/docs/doc-management/api/useDocs.tsx
index d75c5b30..9487684e 100644
--- a/src/frontend/apps/impress/src/features/docs/doc-management/api/useDocs.tsx
+++ b/src/frontend/apps/impress/src/features/docs/doc-management/api/useDocs.tsx
@@ -1,7 +1,8 @@
 import { UseQueryOptions, useQuery } from '@tanstack/react-query';
 
 import { APIError, APIList, errorCauses, fetchAPI } from '@/api';
-import { Doc } from '@/features/docs/doc-management';
+
+import { Doc } from '../types';
 
 export const isDocsOrdering = (data: string): data is DocsOrdering => {
   return !!docsOrdering.find((validKey) => validKey === data);
diff --git a/src/frontend/apps/impress/src/features/docs/doc-management/api/useRemoveDoc.tsx b/src/frontend/apps/impress/src/features/docs/doc-management/api/useRemoveDoc.tsx
index c64ee3b2..21c70ced 100644
--- a/src/frontend/apps/impress/src/features/docs/doc-management/api/useRemoveDoc.tsx
+++ b/src/frontend/apps/impress/src/features/docs/doc-management/api/useRemoveDoc.tsx
@@ -30,7 +30,7 @@ export const useRemoveDoc = (options?: UseRemoveDocOptions) => {
     mutationFn: removeDoc,
     ...options,
     onSuccess: (data, variables, context) => {
-      void queryClient.invalidateQueries({
+      void queryClient.resetQueries({
         queryKey: [KEY_LIST_DOC],
       });
       if (options?.onSuccess) {
diff --git a/src/frontend/apps/impress/src/features/docs/doc-management/api/useUpdateDoc.tsx b/src/frontend/apps/impress/src/features/docs/doc-management/api/useUpdateDoc.tsx
index 79ae14a3..c3868f26 100644
--- a/src/frontend/apps/impress/src/features/docs/doc-management/api/useUpdateDoc.tsx
+++ b/src/frontend/apps/impress/src/features/docs/doc-management/api/useUpdateDoc.tsx
@@ -38,7 +38,7 @@ export function useUpdateDoc({
     mutationFn: updateDoc,
     onSuccess: (data) => {
       listInvalideQueries?.forEach((queryKey) => {
-        void queryClient.invalidateQueries({
+        void queryClient.resetQueries({
           queryKey: [queryKey],
         });
       });
diff --git a/src/frontend/apps/impress/src/features/docs/members/members-add/api/useCreateDocAccess.tsx b/src/frontend/apps/impress/src/features/docs/members/members-add/api/useCreateDocAccess.tsx
index bffed176..1a7b01d2 100644
--- a/src/frontend/apps/impress/src/features/docs/members/members-add/api/useCreateDocAccess.tsx
+++ b/src/frontend/apps/impress/src/features/docs/members/members-add/api/useCreateDocAccess.tsx
@@ -50,7 +50,7 @@ export function useCreateDocAccess() {
   return useMutation<Access, APIError, CreateDocAccessParams>({
     mutationFn: createDocAccess,
     onSuccess: () => {
-      void queryClient.invalidateQueries({
+      void queryClient.resetQueries({
         queryKey: [KEY_LIST_DOC],
       });
       void queryClient.resetQueries({
diff --git a/src/frontend/apps/impress/src/features/docs/members/members-grid/api/useDeleteDocAccess.ts b/src/frontend/apps/impress/src/features/docs/members/members-grid/api/useDeleteDocAccess.ts
index 132a0ee8..1e1943f8 100644
--- a/src/frontend/apps/impress/src/features/docs/members/members-grid/api/useDeleteDocAccess.ts
+++ b/src/frontend/apps/impress/src/features/docs/members/members-grid/api/useDeleteDocAccess.ts
@@ -48,7 +48,7 @@ export const useDeleteDocAccess = (options?: UseDeleteDocAccessOptions) => {
       void queryClient.invalidateQueries({
         queryKey: [KEY_DOC],
       });
-      void queryClient.invalidateQueries({
+      void queryClient.resetQueries({
         queryKey: [KEY_LIST_DOC],
       });
       if (options?.onSuccess) {