From 12ef1a24503814835619f94f1c4f22d454b77d4c Mon Sep 17 00:00:00 2001 From: Anthony LC Date: Mon, 5 May 2025 11:51:32 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=A9(backend)=20default=20enable=20FRON?= =?UTF-8?q?TEND=5FHOMEPAGE=5FFEATURE=5FENABLED?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We decided to enable the FRONTEND_HOMEPAGE_FEATURE_ENABLED feature flag by default. It will not be a breaking change like that. --- env.d/development/common.dist | 1 - src/backend/core/tests/test_api_config.py | 1 - src/backend/impress/settings.py | 2 +- src/helm/env.d/dev/values.impress.yaml.gotmpl | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/env.d/development/common.dist b/env.d/development/common.dist index 471f5aee..451a40a7 100644 --- a/env.d/development/common.dist +++ b/env.d/development/common.dist @@ -64,6 +64,5 @@ COLLABORATION_WS_URL=ws://localhost:4444/collaboration/ws/ # Frontend FRONTEND_THEME=default -FRONTEND_HOMEPAGE_FEATURE_ENABLED=True FRONTEND_FOOTER_FEATURE_ENABLED=True FRONTEND_URL_JSON_FOOTER=http://frontend:3000/contents/footer-demo.json diff --git a/src/backend/core/tests/test_api_config.py b/src/backend/core/tests/test_api_config.py index b86715f0..508ef2c7 100644 --- a/src/backend/core/tests/test_api_config.py +++ b/src/backend/core/tests/test_api_config.py @@ -19,7 +19,6 @@ pytestmark = pytest.mark.django_db COLLABORATION_WS_URL="http://testcollab/", CRISP_WEBSITE_ID="123", FRONTEND_CSS_URL="http://testcss/", - FRONTEND_HOMEPAGE_FEATURE_ENABLED=True, FRONTEND_FOOTER_FEATURE_ENABLED=True, FRONTEND_THEME="test-theme", MEDIA_BASE_URL="http://testserver/", diff --git a/src/backend/impress/settings.py b/src/backend/impress/settings.py index 662ac846..e4932081 100755 --- a/src/backend/impress/settings.py +++ b/src/backend/impress/settings.py @@ -418,7 +418,7 @@ class Base(Configuration): None, environ_name="FRONTEND_THEME", environ_prefix=None ) FRONTEND_HOMEPAGE_FEATURE_ENABLED = values.BooleanValue( - default=False, + default=True, environ_name="FRONTEND_HOMEPAGE_FEATURE_ENABLED", environ_prefix=None, ) diff --git a/src/helm/env.d/dev/values.impress.yaml.gotmpl b/src/helm/env.d/dev/values.impress.yaml.gotmpl index 4f210aea..28686782 100644 --- a/src/helm/env.d/dev/values.impress.yaml.gotmpl +++ b/src/helm/env.d/dev/values.impress.yaml.gotmpl @@ -50,7 +50,6 @@ backend: DB_USER: dinum DB_PASSWORD: pass DB_PORT: 5432 - FRONTEND_HOMEPAGE_FEATURE_ENABLED: true FRONTEND_FOOTER_FEATURE_ENABLED: true FRONTEND_URL_JSON_FOOTER: https://impress.127.0.0.1.nip.io/contents/footer-demo.json POSTGRES_DB: impress