From 1899cff572803d08cf7d9b5c8fe5af0fe8e5d4ae Mon Sep 17 00:00:00 2001
From: Samuel Paccoud - DINUM <samuel.paccoud@mail.numerique.gouv.fr>
Date: Tue, 12 Nov 2024 11:48:04 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(backend)=20fix=20flaky=20test=20by?=
 =?UTF-8?q?=20clarifying=20user=20ordering?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On the user search API by similarity, we had a flaky test because
2 users had the same similarity score. Adding a secondary ordering
field makes ordering deterministic between users who share the same
similarity score.
---
 src/backend/core/api/viewsets.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/core/api/viewsets.py b/src/backend/core/api/viewsets.py
index 3cca5263..607acfea 100644
--- a/src/backend/core/api/viewsets.py
+++ b/src/backend/core/api/viewsets.py
@@ -175,7 +175,7 @@ class UserViewSet(
                 threshold = 0.6 if "@" in query else 0.1
 
                 queryset = queryset.filter(similarity__gt=threshold).order_by(
-                    "-similarity"
+                    "-similarity", "email"
                 )
 
         return queryset