From 304b3be2735804f8a242fc1180edb392294cad79 Mon Sep 17 00:00:00 2001 From: Nathan Panchout Date: Tue, 20 May 2025 10:00:26 +0200 Subject: [PATCH] =?UTF-8?q?=E2=9C=A8(frontend)=20update=20test=20descripti?= =?UTF-8?q?ons=20for=20clarity=20and=20consistency?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - update tests description - Corrected minor typos in test descriptions to enhance readability. - Ensured that all test cases clearly convey their purpose and expected outcomes. --- .../apps/e2e/__tests__/app-impress/common.ts | 15 ++++++++++++--- .../__tests__/app-impress/doc-grid-dnd.spec.ts | 6 +++--- .../e2e/__tests__/app-impress/doc-header.spec.ts | 5 ----- .../app-impress/doc-inherited-share.spec.ts | 10 +++++----- .../e2e/__tests__/app-impress/doc-search.spec.ts | 2 +- .../e2e/__tests__/app-impress/doc-tree.spec.ts | 2 +- 6 files changed, 22 insertions(+), 18 deletions(-) diff --git a/src/frontend/apps/e2e/__tests__/app-impress/common.ts b/src/frontend/apps/e2e/__tests__/app-impress/common.ts index 75100031..d57fd26b 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/common.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/common.ts @@ -242,6 +242,9 @@ export const mockedDocument = async (page: Page, data: object) => { !request.url().includes('accesses') && !request.url().includes('invitations') ) { + const { abilities, ...doc } = data as unknown as { + abilities?: Record; + }; await route.fulfill({ json: { id: 'mocked-document-id', @@ -263,6 +266,7 @@ export const mockedDocument = async (page: Page, data: object) => { authenticated: ['reader', 'editor'], restricted: null, }, + ...abilities, }, link_reach: 'restricted', computed_link_reach: 'restricted', @@ -272,7 +276,7 @@ export const mockedDocument = async (page: Page, data: object) => { created_at: '2021-09-01T09:00:00Z', user_role: 'owner', user_roles: ['owner'], - ...data, + ...doc, }, }); } else { @@ -339,10 +343,10 @@ export const mockedInvitations = async (page: Page, json?: object) => { export const mockedAccesses = async (page: Page, json?: object) => { await page.route('**/accesses/**/', async (route) => { const request = route.request(); + console.log('oui'); if ( request.method().includes('GET') && - request.url().includes('accesses') && - request.url().includes('page=') + request.url().includes('accesses') ) { await route.fulfill({ json: [ @@ -366,6 +370,11 @@ export const mockedAccesses = async (page: Page, json?: object) => { update: true, partial_update: true, retrieve: true, + link_select_options: { + public: ['reader', 'editor'], + authenticated: ['reader', 'editor'], + restricted: null, + }, set_role_to: ['administrator', 'editor'], }, ...json, diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-grid-dnd.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-grid-dnd.spec.ts index 78b284b2..69f97d68 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-grid-dnd.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-grid-dnd.spec.ts @@ -50,7 +50,7 @@ test.describe('Doc grid dnd', () => { await page.mouse.move( dropZoneBoundingBox.x + dropZoneBoundingBox.width / 2, dropZoneBoundingBox.y + dropZoneBoundingBox.height / 2, - { steps: 10 }, // Rendre le mouvement plus fluide + { steps: 10 }, // Make the movement smoother ); const dragOverlay = page.getByTestId('drag-doc-overlay'); @@ -62,7 +62,7 @@ test.describe('Doc grid dnd', () => { await expect(dragOverlay).toBeHidden(); }); - test('it checks cant drop when we have not the minimum role', async ({ + test("it checks can't drop when we have not the minimum role", async ({ page, }) => { await mockedListDocs(page, data); @@ -113,7 +113,7 @@ test.describe('Doc grid dnd', () => { await page.mouse.up(); }); - test('it checks cant drag when we have not the minimum role', async ({ + test("it checks can't drag when we have not the minimum role", async ({ page, }) => { await mockedListDocs(page, data); diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts index 14f77344..6542c1be 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts @@ -109,11 +109,6 @@ test.describe('Doc Header', () => { versions_list: true, versions_retrieve: true, update: true, - link_select_options: { - public: ['reader', 'editor'], - authenticated: ['reader', 'editor'], - restricted: null, - }, partial_update: true, retrieve: true, }, diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-inherited-share.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-inherited-share.spec.ts index f9e3e0a6..8d48abc5 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-inherited-share.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-inherited-share.spec.ts @@ -14,7 +14,7 @@ import { import { createRootSubPage, createSubPageFromParent } from './sub-pages-utils'; test.describe('Inherited share accesses', () => { - test('Vérifie l’héritage des accès', async ({ page, browserName }) => { + test('it checks inherited accesses', async ({ page, browserName }) => { await page.goto('/'); const [titleParent] = await createDoc(page, 'root-doc', browserName, 1); const docTree = page.getByTestId('doc-tree'); @@ -53,7 +53,7 @@ test.describe('Inherited share accesses', () => { await expect(user.getByText('Owner')).toBeVisible(); }); - test('Vérifie le message si il y a un accès hérité', async ({ + test('it checks that the highest role is displayed', async ({ page, browserName, }) => { @@ -107,7 +107,7 @@ test.describe('Inherited share accesses', () => { }); test.describe('Inherited share link', () => { - test('Vérifie si le lien est bien hérité', async ({ page, browserName }) => { + test('it checks if the link is inherited', async ({ page, browserName }) => { await page.goto('/'); // Create root doc await createDoc(page, 'root-doc', browserName, 1); @@ -126,7 +126,7 @@ test.describe('Inherited share link', () => { // await verifyShareLink(page, 'Connected', 'Reading'); }); - test('Vérification du message de warning lorsque les règles de partage diffèrent', async ({ + test('it checks warning message when sharing rules differ', async ({ page, browserName, }) => { @@ -155,7 +155,7 @@ test.describe('Inherited share link', () => { await expect(page.getByText('Sharing rules differ from the')).toBeHidden(); }); - test('Vérification des possibilités de liens hérités', async ({ + test('it checks inherited link possibilities', async ({ page, browserName, }) => { diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-search.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-search.spec.ts index e9f60677..9bdbe01e 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-search.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-search.spec.ts @@ -113,7 +113,7 @@ test.describe('Document search', () => { }); test.describe('Sub page search', () => { - test('it check the precense of filters in search modal', async ({ + test('it check the presence of filters in search modal', async ({ page, browserName, }) => { diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-tree.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-tree.spec.ts index 07a927aa..194427d5 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-tree.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-tree.spec.ts @@ -160,7 +160,7 @@ test.describe('Doc Tree', () => { ); }); - test('it detachs a document', async ({ page, browserName }) => { + test('it detaches a document', async ({ page, browserName }) => { await page.goto('/'); const [docParent] = await createDoc( page,