From 30dfea744a52e5bac464bbad52f9e90dcc3238df Mon Sep 17 00:00:00 2001
From: Anthony LC <anthony.le-courric@mail.numerique.gouv.fr>
Date: Wed, 30 Jul 2025 14:56:30 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(frontend)=20include=20root=20paren?=
 =?UTF-8?q?t=20in=20search?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When searching for documents, the root parent
document is now included in the search
results if it matches the search query.
---
 CHANGELOG.md                                  |  1 +
 .../__tests__/app-impress/doc-search.spec.ts  | 25 +++++++++----------
 .../components/DocSearchSubPageContent.tsx    | 18 ++++++++++++-
 3 files changed, 30 insertions(+), 14 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e2b746f3..9a1f54c1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -31,6 +31,7 @@ and this project adheres to
 - 🐛(frontend) fix empty left panel after deleting root doc #1197
 - 🐛(helm) charts generate invalid YAML for collaboration API / WS #890
 - 🐛(frontend) 401 redirection overridden #1214
+- 🐛(frontend) include root parent in search #1243
 
 ## [3.4.2] - 2025-07-18
 
diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-search.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-search.spec.ts
index c8c09942..d2d54616 100644
--- a/src/frontend/apps/e2e/__tests__/app-impress/doc-search.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-search.spec.ts
@@ -1,6 +1,6 @@
 import { expect, test } from '@playwright/test';
 
-import { createDoc, randomName, verifyDocName } from './utils-common';
+import { createDoc, verifyDocName } from './utils-common';
 import { createRootSubPage } from './utils-sub-pages';
 
 test.beforeEach(async ({ page }) => {
@@ -163,20 +163,12 @@ test.describe('Document search', () => {
     await verifyDocName(page, firstDocTitle);
 
     // Create a new doc - for the moment without children
-    await page.getByRole('button', { name: 'New doc' }).click();
-    await verifyDocName(page, '');
-    await page.getByRole('textbox', { name: 'doc title input' }).click();
-    await page
-      .getByRole('textbox', { name: 'doc title input' })
-      .press('ControlOrMeta+a');
-    const [secondDocTitle] = randomName(
+    const [secondDocTitle] = await createDoc(
+      page,
       'My second sub page search',
       browserName,
       1,
     );
-    await page
-      .getByRole('textbox', { name: 'doc title input' })
-      .fill(secondDocTitle);
 
     const searchButton = page
       .getByTestId('left-panel-desktop')
@@ -199,16 +191,23 @@ test.describe('Document search', () => {
     await page.getByRole('button', { name: 'close' }).click();
 
     // Create a sub page
-    await createRootSubPage(page, browserName, secondDocTitle);
+    const { name: secondChildDocTitle } = await createRootSubPage(
+      page,
+      browserName,
+      'second - Child doc',
+    );
     await searchButton.click();
     await page
       .getByRole('combobox', { name: 'Quick search input' })
-      .fill('sub page search');
+      .fill('second');
 
     // Now there is a sub page - expect to have the focus on the current doc
     await expect(
       page.getByRole('presentation').getByLabel(secondDocTitle),
     ).toBeVisible();
+    await expect(
+      page.getByRole('presentation').getByLabel(secondChildDocTitle),
+    ).toBeVisible();
     await expect(
       page.getByRole('presentation').getByLabel(firstDocTitle),
     ).toBeHidden();
diff --git a/src/frontend/apps/impress/src/features/docs/doc-search/components/DocSearchSubPageContent.tsx b/src/frontend/apps/impress/src/features/docs/doc-search/components/DocSearchSubPageContent.tsx
index e4fa2c7e..4d93a12d 100644
--- a/src/frontend/apps/impress/src/features/docs/doc-search/components/DocSearchSubPageContent.tsx
+++ b/src/frontend/apps/impress/src/features/docs/doc-search/components/DocSearchSubPageContent.tsx
@@ -45,6 +45,16 @@ export const DocSearchSubPageContent = ({
   const docsData: QuickSearchData<Doc> = useMemo(() => {
     const subDocs = subDocsData?.pages.flatMap((page) => page.results) || [];
 
+    if (treeContext?.root) {
+      const isRootTitleIncludeSearch = treeContext.root?.title
+        ?.toLowerCase()
+        .includes(search.toLowerCase());
+
+      if (isRootTitleIncludeSearch) {
+        subDocs.unshift(treeContext.root);
+      }
+    }
+
     return {
       groupName: subDocs.length > 0 ? t('Select a page') : '',
       elements: search ? subDocs : [],
@@ -57,7 +67,13 @@ export const DocSearchSubPageContent = ({
           ]
         : [],
     };
-  }, [search, subDocsData, subDocsFetchNextPage, subDocsHasNextPage]);
+  }, [
+    search,
+    subDocsData?.pages,
+    subDocsFetchNextPage,
+    subDocsHasNextPage,
+    treeContext?.root,
+  ]);
 
   useEffect(() => {
     onLoadingChange?.(loading);