From 38eabe2fc816321e8f692a82435ef3daaf71ac97 Mon Sep 17 00:00:00 2001 From: Anthony LC Date: Mon, 27 May 2024 10:08:29 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=82(frontend)=20right=20pad=20delete?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Manage the right on the pad delete. If a use cannot delete a pad, we will not display the delete button in the dropdown menu. --- CHANGELOG.md | 1 + .../e2e/__tests__/app-impress/pad-tools.spec.ts | 8 +++++++- .../pads/pad-tools/components/PadToolBox.tsx | 16 +++------------- 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 96af9430..283de15c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to ## Added +- Manage the document's right (#75) - Update document (#68) - Remove document (#68) diff --git a/src/frontend/apps/e2e/__tests__/app-impress/pad-tools.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/pad-tools.spec.ts index af6ebd86..6cb402c8 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/pad-tools.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/pad-tools.spec.ts @@ -136,7 +136,10 @@ test.describe('Pad Tools', () => { await expect(panel.locator('li').getByText(randomPad)).toBeHidden(); }); - test('it cannot update if not the owner', async ({ page, browserName }) => { + test('it cannot update or delete if not the owner', async ({ + page, + browserName, + }) => { const [padName] = await createPad( page, 'pad-tools-right-management', @@ -166,5 +169,8 @@ test.describe('Pad Tools', () => { await expect( page.getByRole('button', { name: 'Update document' }), ).toBeHidden(); + await expect( + page.getByRole('button', { name: 'Delete document' }), + ).toBeHidden(); }); }); diff --git a/src/frontend/apps/impress/src/features/pads/pad-tools/components/PadToolBox.tsx b/src/frontend/apps/impress/src/features/pads/pad-tools/components/PadToolBox.tsx index 89881f03..ded53173 100644 --- a/src/frontend/apps/impress/src/features/pads/pad-tools/components/PadToolBox.tsx +++ b/src/frontend/apps/impress/src/features/pads/pad-tools/components/PadToolBox.tsx @@ -72,25 +72,15 @@ export const PadToolBox = ({ pad }: PadToolBoxProps) => { {pad.abilities.destroy && ( )} -