From 42d9fa70a2a0eec89e8638459b4c811e514dfbf3 Mon Sep 17 00:00:00 2001 From: Nathan Panchout Date: Tue, 3 Dec 2024 10:03:07 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A7(frontend)=20remove=20deprecated=20?= =?UTF-8?q?routes=20and=20update=20service=20worker?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Removed the versioning route from the default configuration to streamline the documentation structure. - Updated the service worker to eliminate references to the deprecated versioning fallback, enhancing the offline experience for users. --- src/frontend/apps/impress/conf/default.conf | 4 ---- .../src/features/service-worker/service-worker.ts | 8 -------- .../src/pages/docs/[id]/versions/[versionId].tsx | 13 ------------- .../impress/src/pages/docs/[id]/versions/index.tsx | 13 ------------- 4 files changed, 38 deletions(-) delete mode 100644 src/frontend/apps/impress/src/pages/docs/[id]/versions/[versionId].tsx delete mode 100644 src/frontend/apps/impress/src/pages/docs/[id]/versions/index.tsx diff --git a/src/frontend/apps/impress/conf/default.conf b/src/frontend/apps/impress/conf/default.conf index 684bf17b..5007b3f3 100644 --- a/src/frontend/apps/impress/conf/default.conf +++ b/src/frontend/apps/impress/conf/default.conf @@ -9,10 +9,6 @@ server { try_files $uri index.html $uri/ =404; } - location ~ ^/docs/(.*)/versions/(.*)/$ { - error_page 404 /docs/[id]/versions/[versionId]/; - } - location /docs/ { error_page 404 /docs/[id]/; } diff --git a/src/frontend/apps/impress/src/features/service-worker/service-worker.ts b/src/frontend/apps/impress/src/features/service-worker/service-worker.ts index 3beaada7..77a4f257 100644 --- a/src/frontend/apps/impress/src/features/service-worker/service-worker.ts +++ b/src/frontend/apps/impress/src/features/service-worker/service-worker.ts @@ -91,7 +91,6 @@ self.addEventListener('activate', function (event) { const FALLBACK = { offline: '/offline/', docs: '/docs/[id]/', - versions: '/docs/[id]/versions/[versionId]/', images: '/assets/img-not-found.svg', }; const precacheResources = [ @@ -104,7 +103,6 @@ const precacheResources = [ FALLBACK.offline, FALLBACK.images, FALLBACK.docs, - FALLBACK.versions, ]; const precacheStrategy = getStrategy({ @@ -125,12 +123,6 @@ setCatchHandler(async ({ request, url, event }) => { case request.destination === 'document': if (url.pathname.match(/^\/docs\/([a-z0-9\-]+)\/$/g)) { return precacheStrategy.handle({ event, request: FALLBACK.docs }); - } else if ( - url.pathname.match( - /^\/docs\/([a-z0-9\-]+)\/versions\/([a-z0-9\-]+)\/$/g, - ) - ) { - return precacheStrategy.handle({ event, request: FALLBACK.versions }); } return precacheStrategy.handle({ event, request: FALLBACK.offline }); diff --git a/src/frontend/apps/impress/src/pages/docs/[id]/versions/[versionId].tsx b/src/frontend/apps/impress/src/pages/docs/[id]/versions/[versionId].tsx deleted file mode 100644 index 0eed2ba3..00000000 --- a/src/frontend/apps/impress/src/pages/docs/[id]/versions/[versionId].tsx +++ /dev/null @@ -1,13 +0,0 @@ -import { NextPageWithLayout } from '@/types/next'; - -import { DocLayout } from '../index'; - -const Page: NextPageWithLayout = () => { - return null; -}; - -Page.getLayout = function getLayout() { - return ; -}; - -export default Page; diff --git a/src/frontend/apps/impress/src/pages/docs/[id]/versions/index.tsx b/src/frontend/apps/impress/src/pages/docs/[id]/versions/index.tsx deleted file mode 100644 index 0eed2ba3..00000000 --- a/src/frontend/apps/impress/src/pages/docs/[id]/versions/index.tsx +++ /dev/null @@ -1,13 +0,0 @@ -import { NextPageWithLayout } from '@/types/next'; - -import { DocLayout } from '../index'; - -const Page: NextPageWithLayout = () => { - return null; -}; - -Page.getLayout = function getLayout() { - return ; -}; - -export default Page;