From 57c5c394f5af2f4f617fb0a644c2d49b35bd6bba Mon Sep 17 00:00:00 2001
From: Anthony LC <anthony.le-courric@mail.numerique.gouv.fr>
Date: Wed, 11 Dec 2024 19:48:54 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(backend)=20improve=20sanitizer=20a?=
 =?UTF-8?q?i=5Fservices?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The json response of the AI service is badly formatted.
This commit improves the sanitizer to try
to handle the response correctly.
---
 src/backend/core/services/ai_services.py | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/backend/core/services/ai_services.py b/src/backend/core/services/ai_services.py
index 6c0f92ab..102e8689 100644
--- a/src/backend/core/services/ai_services.py
+++ b/src/backend/core/services/ai_services.py
@@ -69,12 +69,17 @@ class AIService:
         content = response.choices[0].message.content
 
         try:
-            sanitized_content = re.sub(r"(?<!\\)\n", "\\\\n", content)
+            sanitized_content = re.sub(r'\s*"answer"\s*:\s*', '"answer": ', content)
+            sanitized_content = re.sub(r"\s*\}", "}", sanitized_content)
+            sanitized_content = re.sub(r"(?<!\\)\n", "\\\\n", sanitized_content)
             sanitized_content = re.sub(r"(?<!\\)\t", "\\\\t", sanitized_content)
 
             json_response = json.loads(sanitized_content)
         except (json.JSONDecodeError, IndexError):
-            json_response = json.loads(content)
+            try:
+                json_response = json.loads(content)
+            except json.JSONDecodeError as err:
+                raise RuntimeError("AI response is not valid JSON", content) from err
 
         if "answer" not in json_response:
             raise RuntimeError("AI response does not contain an answer")