🔥(back) remove footer endpoint

With the configuration file, the footer endpoint can be removed and will
not be used anymore by the front application.

src/backend/core/api/viewsets.py

@@ -33,7 +33,6 @@ from rest_framework.throttling import UserRateThrottle
 from core import authentication, enums, models
 from core.services.ai_services import AIService
 from core.services.collaboration_services import CollaborationService
-from core.services.config_services import get_footer_json
 from core.utils import extract_attachments, filter_descendants
 
 from . import permissions, serializers, utils
@@ -1734,7 +1733,6 @@ class ConfigView(drf.views.APIView):
             "ENVIRONMENT",
             "FRONTEND_CSS_URL",
             "FRONTEND_HOMEPAGE_FEATURE_ENABLED",
-            "FRONTEND_FOOTER_FEATURE_ENABLED",
             "FRONTEND_THEME",
             "MEDIA_BASE_URL",
             "POSTHOG_KEY",

src/backend/core/services/config_services.py

@@ -1,25 +0,0 @@
-"""Config services."""
-
-import logging
-
-import requests
-
-logger = logging.getLogger(__name__)
-
-
-def get_footer_json(footer_json_url: str) -> dict:
-    """
-    Fetches the footer JSON from the given URL."
-    """
-    try:
-        response = requests.get(
-            footer_json_url, timeout=5, headers={"User-Agent": "Docs-Application"}
-        )
-        response.raise_for_status()
-
-        footer_json = response.json()
-
-        return footer_json
-    except (requests.RequestException, ValueError) as e:
-        logger.error("Failed to fetch footer JSON: %s", e)
-        return {}

src/backend/core/tests/test_api_config.py

@@ -21,7 +21,6 @@ pytestmark = pytest.mark.django_db
     COLLABORATION_WS_URL="http://testcollab/",
     CRISP_WEBSITE_ID="123",
     FRONTEND_CSS_URL="http://testcss/",
-    FRONTEND_FOOTER_FEATURE_ENABLED=True,
     FRONTEND_THEME="test-theme",
     MEDIA_BASE_URL="http://testserver/",
     POSTHOG_KEY={"id": "132456", "host": "https://eu.i.posthog-test.com"},
@@ -45,7 +44,6 @@ def test_api_config(is_authenticated):
         "ENVIRONMENT": "test",
         "FRONTEND_CSS_URL": "http://testcss/",
         "FRONTEND_HOMEPAGE_FEATURE_ENABLED": True,
-        "FRONTEND_FOOTER_FEATURE_ENABLED": True,
         "FRONTEND_THEME": "test-theme",
         "LANGUAGES": [
             ["en-us", "English"],

src/backend/core/tests/test_api_footer.py

@@ -1,81 +0,0 @@
-"""Test the footer API."""
-
-import responses
-from rest_framework.test import APIClient
-
-
-def test_api_footer_without_settings_configured(settings):
-    """Test the footer API without settings configured."""
-    settings.FRONTEND_URL_JSON_FOOTER = None
-    client = APIClient()
-    response = client.get("/api/v1.0/footer/")
-    assert response.status_code == 200
-    assert response.json() == {}
-
-
-@responses.activate
-def test_api_footer_with_invalid_request(settings):
-    """Test the footer API with an invalid request."""
-    settings.FRONTEND_URL_JSON_FOOTER = "https://invalid-request.com"
-
-    footer_response = responses.get(settings.FRONTEND_URL_JSON_FOOTER, status=404)
-
-    client = APIClient()
-    response = client.get("/api/v1.0/footer/")
-    assert response.status_code == 200
-    assert response.json() == {}
-    assert footer_response.call_count == 1
-
-
-@responses.activate
-def test_api_footer_with_invalid_json(settings):
-    """Test the footer API with an invalid JSON response."""
-    settings.FRONTEND_URL_JSON_FOOTER = "https://valid-request.com"
-
-    footer_response = responses.get(
-        settings.FRONTEND_URL_JSON_FOOTER, status=200, body="invalid json"
-    )
-
-    client = APIClient()
-    response = client.get("/api/v1.0/footer/")
-    assert response.status_code == 200
-    assert response.json() == {}
-    assert footer_response.call_count == 1
-
-
-@responses.activate
-def test_api_footer_with_valid_json(settings):
-    """Test the footer API with an invalid JSON response."""
-    settings.FRONTEND_URL_JSON_FOOTER = "https://valid-request.com"
-
-    footer_response = responses.get(
-        settings.FRONTEND_URL_JSON_FOOTER, status=200, json={"foo": "bar"}
-    )
-
-    client = APIClient()
-    response = client.get("/api/v1.0/footer/")
-    assert response.status_code == 200
-    assert response.json() == {"foo": "bar"}
-    assert footer_response.call_count == 1
-
-
-@responses.activate
-def test_api_footer_with_valid_json_and_cache(settings):
-    """Test the footer API with an invalid JSON response."""
-    settings.FRONTEND_URL_JSON_FOOTER = "https://valid-request.com"
-
-    footer_response = responses.get(
-        settings.FRONTEND_URL_JSON_FOOTER, status=200, json={"foo": "bar"}
-    )
-
-    client = APIClient()
-    response = client.get("/api/v1.0/footer/")
-    assert response.status_code == 200
-    assert response.json() == {"foo": "bar"}
-    assert footer_response.call_count == 1
-
-    response = client.get("/api/v1.0/footer/")
-    assert response.status_code == 200
-    assert response.json() == {"foo": "bar"}
-    # The cache should have been used
-    assert footer_response.call_count == 1

src/backend/core/urls.py

@@ -56,5 +56,4 @@ urlpatterns = [
         ),
     ),
     path(f"api/{settings.API_VERSION}/config/", viewsets.ConfigView.as_view()),
-    path(f"api/{settings.API_VERSION}/footer/", viewsets.FooterView.as_view()),
 ]

src/backend/impress/settings.py

@@ -423,19 +423,6 @@ class Base(Configuration):
         environ_name="FRONTEND_HOMEPAGE_FEATURE_ENABLED",
         environ_prefix=None,
     )
-    FRONTEND_URL_JSON_FOOTER = values.Value(
-        None, environ_name="FRONTEND_URL_JSON_FOOTER", environ_prefix=None
-    )
-    FRONTEND_FOOTER_FEATURE_ENABLED = values.BooleanValue(
-        default=False,
-        environ_name="FRONTEND_FOOTER_FEATURE_ENABLED",
-        environ_prefix=None,
-    )
-    FRONTEND_FOOTER_VIEW_CACHE_TIMEOUT = values.Value(
-        60 * 60 * 24,
-        environ_name="FRONTEND_FOOTER_VIEW_CACHE_TIMEOUT",
-        environ_prefix=None,
-    )
     FRONTEND_CSS_URL = values.Value(
         None, environ_name="FRONTEND_CSS_URL", environ_prefix=None
     )