diff --git a/CHANGELOG.md b/CHANGELOG.md index d6d4c544..ce550298 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,6 +25,10 @@ and this project adheres to - #1341 - ♻️(tilt) use helm dev-backend chart +### Fixed + +- 🐛(frontend) fix callout emoji list #1366 + ## [3.6.0] - 2025-09-04 ### Added diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-editor.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-editor.spec.ts index ec4cd2bc..06a273ae 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-editor.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-editor.spec.ts @@ -703,8 +703,20 @@ test.describe('Doc Editor', () => { const emojiButton = calloutBlock.getByRole('button'); await expect(emojiButton).toHaveText('💡'); await emojiButton.click(); - await page.locator('button[aria-label="⚠️"]').click(); - await expect(emojiButton).toHaveText('⚠️'); + // Group smiley + await expect(page.getByRole('button', { name: '🤠' })).toBeVisible(); + // Group animals + await page.getByText('Animals & Nature').scrollIntoViewIfNeeded(); + await expect(page.getByRole('button', { name: '🦆' })).toBeVisible(); + // Group travel + await page.getByText('Travel & Places').scrollIntoViewIfNeeded(); + await expect(page.getByRole('button', { name: '🚝' })).toBeVisible(); + // Group objects + await page.getByText('Objects').scrollIntoViewIfNeeded(); + await expect(page.getByRole('button', { name: '🪇' })).toBeVisible(); + // Group symbol + await page.getByText('Symbols').scrollIntoViewIfNeeded(); + await expect(page.getByRole('button', { name: '🛃' })).toBeVisible(); await page.locator('.bn-side-menu > button').last().click(); await page.locator('.mantine-Menu-dropdown > button').last().click(); diff --git a/src/frontend/apps/impress/src/features/docs/doc-editor/components/EmojiPicker.tsx b/src/frontend/apps/impress/src/features/docs/doc-editor/components/EmojiPicker.tsx index 8c5f5b79..514f8890 100644 --- a/src/frontend/apps/impress/src/features/docs/doc-editor/components/EmojiPicker.tsx +++ b/src/frontend/apps/impress/src/features/docs/doc-editor/components/EmojiPicker.tsx @@ -7,14 +7,12 @@ import { Box } from '@/components'; interface EmojiPickerProps { emojiData: EmojiMartData; - categories: string[]; onClickOutside: () => void; onEmojiSelect: ({ native }: { native: string }) => void; } export const EmojiPicker = ({ emojiData, - categories, onClickOutside, onEmojiSelect, }: EmojiPickerProps) => { @@ -24,7 +22,6 @@ export const EmojiPicker = ({ diff --git a/src/frontend/apps/impress/src/features/docs/doc-editor/components/custom-blocks/initEmojiCallout.ts b/src/frontend/apps/impress/src/features/docs/doc-editor/components/custom-blocks/initEmojiCallout.ts index b104568b..4df96e82 100644 --- a/src/frontend/apps/impress/src/features/docs/doc-editor/components/custom-blocks/initEmojiCallout.ts +++ b/src/frontend/apps/impress/src/features/docs/doc-editor/components/custom-blocks/initEmojiCallout.ts @@ -56,21 +56,4 @@ if (!emojidata.categories.some((c) => c.id === CALLOUT_ID)) { void init({ data: emojidata }); -const calloutCategories = [ - 'callout', - 'people', - 'nature', - 'foods', - 'activity', - 'places', - 'flags', - 'objects', - 'symbols', -]; - -const calloutEmojiData = { - emojidata, - calloutCategories, -}; - -export default calloutEmojiData; +export default emojidata;