studio/docs
Archived
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

✅(backend) fix flaky test on tmp file

Browse Source 
It seems to have a race condition, sometimes the
tmp file is not deleted before the test assertion.
We let the test sleep for 0.5 second before
the assertion.
This commit is contained in:
Anthony LC
2024-09-23 17:19:13 +02:00
committed by Anthony LC
parent 358508ffa3
commit 7b04f664cd
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/core/tests/test_models_templates.py
View File

@@ -3,6 +3,7 @@ Unit tests for the Template model
""" """
import os import os
import time
from unittest import mock from unittest import mock
from django.contrib.auth.models import AnonymousUser from django.contrib.auth.models import AnonymousUser
@@ -203,7 +204,7 @@ def test_models_templates__generate_word():
"pypandoc.convert_text", "pypandoc.convert_text",
side_effect=RuntimeError("Conversion failed"), side_effect=RuntimeError("Conversion failed"),
) )
def test_models_templates__generate_word__raise_error(_mock_send_mail): def test_models_templates__generate_word__raise_error(_mock_pypandoc):
""" """
Generate word document and assert no tmp files are left in /tmp folder Generate word document and assert no tmp files are left in /tmp folder
even when the conversion fails. even when the conversion fails.
@@ -214,4 +215,5 @@ def test_models_templates__generate_word__raise_error(_mock_send_mail):
template.generate_word("<p>Test body</p>", {}) template.generate_word("<p>Test body</p>", {})
except RuntimeError as e: except RuntimeError as e:
assert str(e) == "Conversion failed" assert str(e) == "Conversion failed"
time.sleep(0.5)
assert len([f for f in os.listdir("/tmp") if f.startswith("docx_")]) == 0 assert len([f for f in os.listdir("/tmp") if f.startswith("docx_")]) == 0