From 86fdbeacaa8dc11b7c63747613db565ca8739037 Mon Sep 17 00:00:00 2001 From: Anthony LC Date: Wed, 4 Sep 2024 21:19:49 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A5(frontend)=20do=20not=20display=20f?= =?UTF-8?q?eature=20version?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A bug was found in the version feature. A 404 error appears sometimes, probably because of Minio that does not keep enough versions. We want to do a realease, so we will remove the version feature for now. --- CHANGELOG.md | 1 - .../__tests__/app-impress/doc-version.spec.ts | 201 ------------------ .../docs/doc-header/components/DocToolBox.tsx | 14 -- 3 files changed, 216 deletions(-) delete mode 100644 src/frontend/apps/e2e/__tests__/app-impress/doc-version.spec.ts diff --git a/CHANGELOG.md b/CHANGELOG.md index 47d390dd..085bc963 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,7 +13,6 @@ and this project adheres to - ✨Add image attachments with access control - ✨(frontend) Upload image to a document #211 -- ✨(frontend) Versions #217 - ✨(frontend) Summary #223 ## Changed diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-version.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-version.spec.ts deleted file mode 100644 index 1c3bfc81..00000000 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-version.spec.ts +++ /dev/null @@ -1,201 +0,0 @@ -import { expect, test } from '@playwright/test'; - -import { createDoc, goToGridDoc, mockedDocument } from './common'; - -test.beforeEach(async ({ page }) => { - await page.goto('/'); -}); - -test.describe('Doc Version', () => { - test('it displays the doc versions', async ({ page, browserName }) => { - const [randomDoc] = await createDoc(page, 'doc-version', browserName, 1); - - await expect(page.locator('h2').getByText(randomDoc)).toBeVisible(); - - await page.getByLabel('Open the document options').click(); - await page - .getByRole('button', { - name: 'Version history', - }) - .click(); - - const panel = page.getByLabel('Document panel'); - - await expect(panel.getByText('Current version')).toBeVisible(); - expect(await panel.locator('li').count()).toBe(1); - - await page.locator('.ProseMirror.bn-editor').click(); - await page.locator('.ProseMirror.bn-editor').last().fill('Hello World'); - - await goToGridDoc(page, { - title: randomDoc, - }); - - await expect(page.getByText('Hello World')).toBeVisible(); - - await page - .locator('.ProseMirror .bn-block') - .getByText('Hello World') - .fill('It will create a version'); - - await goToGridDoc(page, { - title: randomDoc, - }); - - await expect(page.getByText('Hello World')).toBeHidden(); - await expect(page.getByText('It will create a version')).toBeVisible(); - - await page.getByLabel('Open the document options').click(); - await page - .getByRole('button', { - name: 'Version history', - }) - .click(); - - await expect(panel.getByText('Current version')).toBeVisible(); - expect(await panel.locator('li').count()).toBe(2); - - await panel.locator('li').nth(1).click(); - await expect( - page.getByText('Read only, you cannot edit document versions.'), - ).toBeVisible(); - await expect(page.getByText('Hello World')).toBeVisible(); - await expect(page.getByText('It will create a version')).toBeHidden(); - - await panel.getByText('Current version').click(); - await expect(page.getByText('Hello World')).toBeHidden(); - await expect(page.getByText('It will create a version')).toBeVisible(); - }); - - test('it does not display the doc versions if not allowed', async ({ - page, - }) => { - await mockedDocument(page, { - abilities: { - versions_list: false, - partial_update: true, - }, - }); - - await goToGridDoc(page); - - await expect(page.locator('h2').getByText('Mocked document')).toBeVisible(); - - await page.getByLabel('Open the document options').click(); - await expect( - page.getByRole('button', { name: 'Version history' }), - ).toBeHidden(); - - await expect(page.getByLabel('Document panel')).toBeHidden(); - }); - - test('it restores the doc version', async ({ page, browserName }) => { - const [randomDoc] = await createDoc(page, 'doc-version', browserName, 1); - - await expect(page.locator('h2').getByText(randomDoc)).toBeVisible(); - - await page.locator('.bn-block-outer').last().click(); - await page.locator('.bn-block-outer').last().fill('Hello'); - - await goToGridDoc(page, { - title: randomDoc, - }); - - await expect(page.getByText('Hello')).toBeVisible(); - await page.locator('.bn-block-outer').last().click(); - await page.keyboard.press('Enter'); - await page.locator('.bn-block-outer').last().fill('World'); - - await goToGridDoc(page, { - title: randomDoc, - }); - - await expect(page.getByText('World')).toBeVisible(); - - await page.getByLabel('Open the document options').click(); - await page - .getByRole('button', { - name: 'Version history', - }) - .click(); - - const panel = page.getByLabel('Document panel'); - await panel.locator('li').nth(1).click(); - await expect(page.getByText('World')).toBeHidden(); - - await panel.getByLabel('Open the version options').click(); - await page.getByText('Restore the version').click(); - - await expect(page.getByText('Restore this version?')).toBeVisible(); - - await page - .getByRole('button', { - name: 'Restore', - }) - .click(); - - await expect(panel.locator('li')).toHaveCount(3); - - await panel.getByText('Current version').click(); - await expect(page.getByText('Hello')).toBeVisible(); - await expect(page.getByText('World')).toBeHidden(); - }); - - test('it restores the doc version from button title', async ({ - page, - browserName, - }) => { - const [randomDoc] = await createDoc(page, 'doc-version', browserName, 1); - - await expect(page.locator('h2').getByText(randomDoc)).toBeVisible(); - - await page.locator('.bn-block-outer').last().click(); - await page.locator('.bn-block-outer').last().fill('Hello'); - - await goToGridDoc(page, { - title: randomDoc, - }); - - await expect(page.getByText('Hello')).toBeVisible(); - await page.locator('.bn-block-outer').last().click(); - await page.keyboard.press('Enter'); - await page.locator('.bn-block-outer').last().fill('World'); - - await goToGridDoc(page, { - title: randomDoc, - }); - - await expect(page.getByText('World')).toBeVisible(); - - await page.getByLabel('Open the document options').click(); - await page - .getByRole('button', { - name: 'Version history', - }) - .click(); - - const panel = page.getByLabel('Document panel'); - await panel.locator('li').nth(1).click(); - await expect(page.getByText('World')).toBeHidden(); - - await page - .getByRole('button', { - name: 'Restore this version', - }) - .click(); - - await expect(page.getByText('Restore this version?')).toBeVisible(); - - await page - .getByRole('button', { - name: 'Restore', - }) - .click(); - - await expect(panel.locator('li')).toHaveCount(3); - - await panel.getByText('Current version').click(); - await expect(page.getByText('Hello')).toBeVisible(); - await expect(page.getByText('World')).toBeHidden(); - }); -}); diff --git a/src/frontend/apps/impress/src/features/docs/doc-header/components/DocToolBox.tsx b/src/frontend/apps/impress/src/features/docs/doc-header/components/DocToolBox.tsx index 9b9ab47f..9e00a88a 100644 --- a/src/frontend/apps/impress/src/features/docs/doc-header/components/DocToolBox.tsx +++ b/src/frontend/apps/impress/src/features/docs/doc-header/components/DocToolBox.tsx @@ -81,20 +81,6 @@ export const DocToolBox = ({ doc }: DocToolBoxProps) => { {t('Delete document')} )} - {doc.abilities.versions_list && ( - - )}