🎨(frontend) stop limit layout height to screen size

The app was limiting the layout height to the screen size,
which was a bit annoying when the content was
bigger than the screen.
We stop doing that, and now the layout
will grow as needed.
This commit is contained in:
Anthony LC
2024-08-06 11:42:13 +02:00
committed by Anthony LC
parent 713d9e48c8
commit 8d5648005f
6 changed files with 13 additions and 10 deletions

View File

@@ -17,6 +17,10 @@ and this project adheres to
- 🐛(y-webrtc) fix prob connection #147 - 🐛(y-webrtc) fix prob connection #147
## Changed
- 🎨(frontend) stop limit layout height to screen size #158
## [1.1.0] - 2024-07-15 ## [1.1.0] - 2024-07-15
## Added ## Added

View File

@@ -17,7 +17,7 @@ test.describe('Documents Grid', () => {
await expect(thead.getByText(/Created at/i)).toBeVisible(); await expect(thead.getByText(/Created at/i)).toBeVisible();
await expect(thead.getByText(/Updated at/i)).toBeVisible(); await expect(thead.getByText(/Updated at/i)).toBeVisible();
await expect(thead.getByText(/Your role/i)).toBeVisible(); await expect(thead.getByText(/Your role/i)).toBeVisible();
await expect(thead.getByText(/Users number/i)).toBeVisible(); await expect(thead.getByText(/Members/i)).toBeVisible();
const row1 = datagrid.getByRole('row').nth(1).getByRole('cell'); const row1 = datagrid.getByRole('row').nth(1).getByRole('cell');
const docName = await row1.nth(1).textContent(); const docName = await row1.nth(1).textContent();

View File

@@ -54,7 +54,6 @@ export const DocEditor = ({ doc }: DocEditorProps) => {
$direction="row" $direction="row"
$margin={{ all: 'small', top: 'none' }} $margin={{ all: 'small', top: 'none' }}
$gap="1rem" $gap="1rem"
$overflow="auto"
> >
<Card $padding="big" $css="flex:1;" $overflow="auto"> <Card $padding="big" $css="flex:1;" $overflow="auto">
{isVersion ? ( {isVersion ? (

View File

@@ -29,8 +29,11 @@ export const Panel = ({ doc }: PanelProps) => {
<Card <Card
$width="100%" $width="100%"
$maxWidth="20rem" $maxWidth="20rem"
$position="relative" $position="sticky"
$maxHeight="96vh"
$height="100%"
$css={` $css={`
top: 2vh;
transition: ${transition}; transition: ${transition};
${ ${
!isOpen && !isOpen &&
@@ -50,7 +53,7 @@ export const Panel = ({ doc }: PanelProps) => {
? t('Close the document version panel') ? t('Close the document version panel')
: t('Open the document version panel') : t('Open the document version panel')
} }
$background="white" $background="transparent"
$size="h2" $size="h2"
$zIndex={1} $zIndex={1}
$css={` $css={`

View File

@@ -20,9 +20,6 @@ import { PAGE_SIZE } from '../conf';
import { DocsGridActions } from './DocsGridActions'; import { DocsGridActions } from './DocsGridActions';
const DocsGridStyle = createGlobalStyle` const DocsGridStyle = createGlobalStyle`
& .c__datagrid{
max-height: 91%;
}
& .c__datagrid thead{ & .c__datagrid thead{
position: sticky; position: sticky;
top: 0; top: 0;
@@ -171,7 +168,7 @@ export const DocsGrid = () => {
}, },
}, },
{ {
headerName: t('Users number'), headerName: t('Members'),
id: 'users_number', id: 'users_number',
renderCell: ({ row }) => { renderCell: ({ row }) => {
return ( return (

View File

@@ -8,12 +8,12 @@ export function MainLayout({ children }: { children: React.ReactNode }) {
return ( return (
<Box> <Box>
<Box $height="100vh"> <Box $minHeight="100vh">
<Header /> <Header />
<Box $css="flex: 1;" $direction="row"> <Box $css="flex: 1;" $direction="row">
<Box <Box
as="main" as="main"
$height={`calc(100vh - ${HEADER_HEIGHT})`} $minHeight={`calc(100vh - ${HEADER_HEIGHT})`}
$width="100%" $width="100%"
$background={colorsTokens()['primary-bg']} $background={colorsTokens()['primary-bg']}
> >