studio/docs
Archived
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

💡(backend) warm about the token nature of Yprovider microservice

Browse Source 
Note to the future myself, using a raw token format is
not common. It should be refactor
This commit is contained in:
lebaudantoine
2024-12-15 18:52:37 +01:00
committed by aleb_the_flash
parent c10808b611
commit 8eb986591a
3 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/backend/core/services/collaboration_services.py
View File

@@ -26,6 +26,7 @@ class CollaborationService:
# same pod thanks to a parameter # same pod thanks to a parameter
endpoint_url = f"{settings.COLLABORATION_API_URL}{endpoint}/?room={room}" endpoint_url = f"{settings.COLLABORATION_API_URL}{endpoint}/?room={room}"
# Note: Collaboration microservice accepts only raw token, which is not recommended
headers = {"Authorization": settings.COLLABORATION_SERVER_SECRET} headers = {"Authorization": settings.COLLABORATION_SERVER_SECRET}
if user_id: if user_id:
headers["X-User-Id"] = user_id headers["X-User-Id"] = user_id

1
src/backend/core/services/converter_services.py
View File

@@ -31,6 +31,7 @@ class YdocConverter:
@property @property
def auth_header(self): def auth_header(self):
"""Build microservice authentication header.""" """Build microservice authentication header."""
# Note: Yprovider microservice accepts only raw token, which is not recommended
return settings.Y_PROVIDER_API_KEY return settings.Y_PROVIDER_API_KEY
def convert_markdown(self, text): def convert_markdown(self, text):

1
src/frontend/servers/y-provider/src/middlewares.ts
View File

@@ -25,6 +25,7 @@ export const httpSecurity = (
} }
// Secret API Key check // Secret API Key check
// Note: Changing this header to Bearer token format will break backend compatibility with this microservice.
const apiKey = req.headers['authorization']; const apiKey = req.headers['authorization'];
if (apiKey !== COLLABORATION_SERVER_SECRET) { if (apiKey !== COLLABORATION_SERVER_SECRET) {
res.status(403).json({ error: 'Forbidden: Invalid API Key' }); res.status(403).json({ error: 'Forbidden: Invalid API Key' });