diff --git a/CHANGELOG.md b/CHANGELOG.md index 0f771d60..9e1f3311 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ and this project adheres to - ✨(ci) add security scan #291 - ✨(frontend) Activate versions feature #240 - ✨(frontend) one-click document creation #275 +- ✨(frontend) edit title inline #275 ## Changed diff --git a/src/frontend/apps/e2e/__tests__/app-impress/common.ts b/src/frontend/apps/e2e/__tests__/app-impress/common.ts index 1cab233f..c09bc713 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/common.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/common.ts @@ -29,32 +29,21 @@ export const createDoc = async ( length: number, isPublic: boolean = false, ) => { - const buttonCreate = page.getByRole('button', { - name: 'Create the document', - }); - const randomDocs = randomName(docName, browserName, length); for (let i = 0; i < randomDocs.length; i++) { const header = page.locator('header').first(); await header.locator('h2').getByText('Docs').click(); - const buttonCreateHomepage = page.getByRole('button', { - name: 'Create a new document', - }); - await buttonCreateHomepage.click(); - - // Fill input await page - .getByRole('textbox', { - name: 'Document name', + .getByRole('button', { + name: 'Create a new document', }) - .fill(randomDocs[i]); + .click(); - await expect(buttonCreate).toBeEnabled(); - await buttonCreate.click(); - - await expect(page.locator('h2').getByText(randomDocs[i])).toBeVisible(); + await page.getByRole('heading', { name: 'Untitled document' }).click(); + await page.keyboard.type(randomDocs[i]); + await page.getByText('Created at ').click(); if (isPublic) { await page.getByRole('button', { name: 'Share' }).click(); diff --git a/src/frontend/apps/impress/src/features/docs/doc-header/components/DocHeader.tsx b/src/frontend/apps/impress/src/features/docs/doc-header/components/DocHeader.tsx index 4f551109..3c563707 100644 --- a/src/frontend/apps/impress/src/features/docs/doc-header/components/DocHeader.tsx +++ b/src/frontend/apps/impress/src/features/docs/doc-header/components/DocHeader.tsx @@ -8,12 +8,13 @@ import { Doc, Role, currentDocRole, - useTransRole, + useTrans, } from '@/features/docs/doc-management'; import { ModalVersion, Versions } from '@/features/docs/doc-versioning'; import { useDate } from '@/hook'; import { DocTagPublic } from './DocTagPublic'; +import { DocTitle } from './DocTitle'; import { DocToolBox } from './DocToolBox'; interface DocHeaderProps { @@ -25,7 +26,7 @@ export const DocHeader = ({ doc, versionId }: DocHeaderProps) => { const { colorsTokens } = useCunninghamTheme(); const { t } = useTranslation(); const { formatDate } = useDate(); - const transRole = useTransRole(); + const { transRole } = useTrans(); const [isModalVersionOpen, setIsModalVersionOpen] = useState(false); return ( @@ -54,14 +55,8 @@ export const DocHeader = ({ doc, versionId }: DocHeaderProps) => { $background={colorsTokens()['greyscale-100']} $margin={{ horizontal: 'small' }} /> - - - {doc.title} - + + {versionId && (