From 9c67c9e4d4d8b24ac1371140752a55a9c63de112 Mon Sep 17 00:00:00 2001
From: Anthony LC <anthony.le-courric@mail.numerique.gouv.fr>
Date: Wed, 21 Aug 2024 16:42:15 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A5(helm)=20remove=20htaccess?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

We will not use htaccess anymore,
so we can remove it from the project.
---
 CHANGELOG.md                                         | 4 ++++
 src/helm/env.d/preprod/values.impress.yaml.gotmpl    | 6 ------
 src/helm/env.d/production/values.impress.yaml.gotmpl | 6 ------
 src/helm/impress/templates/secret.yaml               | 9 ---------
 4 files changed, 4 insertions(+), 21 deletions(-)
 delete mode 100644 src/helm/impress/templates/secret.yaml

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5d76c65a..2886f18b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -29,6 +29,10 @@ and this project adheres to
 - 🎨(frontend) stop limit layout height to screen size #158
 - ⚡️(CI) only e2e chrome mandatory #177
 
+## Removed
+- 🔥(helm) remove htaccess #181
+
+
 ## [1.1.0] - 2024-07-15
 
 ## Added
diff --git a/src/helm/env.d/preprod/values.impress.yaml.gotmpl b/src/helm/env.d/preprod/values.impress.yaml.gotmpl
index d8168552..8793e18a 100644
--- a/src/helm/env.d/preprod/values.impress.yaml.gotmpl
+++ b/src/helm/env.d/preprod/values.impress.yaml.gotmpl
@@ -130,9 +130,6 @@ ingress:
   className: nginx
   annotations:
     cert-manager.io/cluster-issuer: letsencrypt-prod
-    nginx.ingress.kubernetes.io/auth-type: basic
-    nginx.ingress.kubernetes.io/auth-secret: htaccess
-    nginx.ingress.kubernetes.io/auth-realm: 'Authentication Required'
 
 ingressWS:
   enabled: true
@@ -140,9 +137,6 @@ ingressWS:
   className: nginx
   annotations:
     cert-manager.io/cluster-issuer: letsencrypt-prod
-    nginx.ingress.kubernetes.io/auth-type: basic
-    nginx.ingress.kubernetes.io/auth-secret: htaccess
-    nginx.ingress.kubernetes.io/auth-realm: 'Authentication Required'
 
 ingressAdmin:
   enabled: true
diff --git a/src/helm/env.d/production/values.impress.yaml.gotmpl b/src/helm/env.d/production/values.impress.yaml.gotmpl
index ec99840f..f618e7d5 100644
--- a/src/helm/env.d/production/values.impress.yaml.gotmpl
+++ b/src/helm/env.d/production/values.impress.yaml.gotmpl
@@ -130,9 +130,6 @@ ingress:
   className: nginx
   annotations:
     cert-manager.io/cluster-issuer: letsencrypt
-    nginx.ingress.kubernetes.io/auth-type: basic
-    nginx.ingress.kubernetes.io/auth-secret: htaccess
-    nginx.ingress.kubernetes.io/auth-realm: 'Authentication Required'
 
 ingressWS:
   enabled: true
@@ -140,9 +137,6 @@ ingressWS:
   className: nginx
   annotations:
     cert-manager.io/cluster-issuer: letsencrypt
-    nginx.ingress.kubernetes.io/auth-type: basic
-    nginx.ingress.kubernetes.io/auth-secret: htaccess
-    nginx.ingress.kubernetes.io/auth-realm: 'Authentication Required'
 
 ingressAdmin:
   enabled: true
diff --git a/src/helm/impress/templates/secret.yaml b/src/helm/impress/templates/secret.yaml
deleted file mode 100644
index 1a06a2d0..00000000
--- a/src/helm/impress/templates/secret.yaml
+++ /dev/null
@@ -1,9 +0,0 @@
-{{ if .Values.htaccess }}
-apiVersion: v1
-kind: Secret
-metadata:
-  name: htaccess
-  namespace: {{ .Release.Namespace | quote }}
-stringData:
-  auth: {{ .Values.htaccess }}
-{{ end }}