🚨(backend) fix linting issues after upgrading

The last upgrades introduced some linting issues.
This commit fixes them.

src/backend/core/tests/authentication/test_backends.py

@@ -92,9 +92,12 @@ def test_models_oidc_user_getter_invalid_token(django_assert_num_queries, monkey
 
     monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
 
-    with django_assert_num_queries(0), pytest.raises(
-        SuspiciousOperation,
-        match="User info contained no recognizable user identification",
+    with (
+        django_assert_num_queries(0),
+        pytest.raises(
+            SuspiciousOperation,
+            match="User info contained no recognizable user identification",
+        ),
     ):
         klass.get_or_create_user(access_token="test-token", id_token=None, payload=None)
 

src/backend/core/tests/conftest.py

@@ -1,4 +1,5 @@
 """Fixtures for tests in the impress core application"""
+
 from unittest import mock
 
 import pytest

src/backend/core/tests/documents/test_api_document_accesses.py

@@ -1,6 +1,7 @@
 """
 Test document accesses API endpoints for users in impress's core app.
 """
+
 import random
 from uuid import uuid4
 
@@ -67,6 +68,7 @@ def test_api_document_accesses_list_authenticated_related(via, mock_user_get_tea
     client.force_login(user)
 
     document = factories.DocumentFactory()
+    user_access = None
     if via == USER:
         user_access = models.DocumentAccess.objects.create(
             document=document,
@@ -543,6 +545,7 @@ def test_api_document_accesses_update_owner_self(via, mock_user_get_teams):
     client.force_login(user)
 
     document = factories.DocumentFactory()
+    access = None
     if via == USER:
         access = factories.UserDocumentAccessFactory(
             document=document, user=user, role="owner"
@@ -773,6 +776,7 @@ def test_api_document_accesses_delete_owners_last_owner(via, mock_user_get_teams
     client.force_login(user)
 
     document = factories.DocumentFactory()
+    access = None
     if via == USER:
         access = factories.UserDocumentAccessFactory(
             document=document, user=user, role="owner"

src/backend/core/tests/documents/test_api_document_accesses_create.py

@@ -1,6 +1,7 @@
 """
 Test document accesses API endpoints for users in impress's core app.
 """
+
 import random
 
 from django.core import mail

src/backend/core/tests/documents/test_api_document_invitations.py

@@ -1,6 +1,7 @@
 """
 Unit tests for the Invitation model
 """
+
 import random
 import time
 
@@ -250,7 +251,7 @@ def test_api_document_invitations__create__cannot_duplicate_invitation():
     )
 
     assert response.status_code == status.HTTP_400_BAD_REQUEST
-    assert response.json()["__all__"] == [
+    assert response.json() == [
         "Document invitation with this Email address and Document already exists."
     ]
 
@@ -278,9 +279,7 @@ def test_api_document_invitations__create__cannot_invite_existing_users():
     )
 
     assert response.status_code == status.HTTP_400_BAD_REQUEST
-    assert response.json()["email"] == [
-        "This email is already associated to a registered user."
-    ]
+    assert response.json() == ["This email is already associated to a registered user."]
 
 
 def test_api_document_invitations__list__anonymous_user():
@@ -567,8 +566,9 @@ def test_api_document_invitations__update__forbidden__not_authenticated(
     client = APIClient()
     client.force_login(user)
     url = f"/api/v1.0/documents/{invitation.document.id}/invitations/{invitation.id}/"
-    if method == "put":
-        response = client.put(url)
+
+    response = client.put(url)
+
     if method == "patch":
         response = client.patch(url)
 

src/backend/core/tests/documents/test_api_document_versions.py

@@ -1,6 +1,7 @@
 """
 Test document versions API endpoints for users in impress's core app.
 """
+
 import random
 import time
 

src/backend/core/tests/documents/test_api_documents_create.py

@@ -1,6 +1,7 @@
 """
 Tests for Documents API endpoint in impress's core app: create
 """
+
 import uuid
 
 import pytest

src/backend/core/tests/documents/test_api_documents_delete.py

@@ -1,6 +1,7 @@
 """
 Tests for Documents API endpoint in impress's core app: delete
 """
+
 import random
 
 import pytest

src/backend/core/tests/documents/test_api_documents_list.py

@@ -1,6 +1,7 @@
 """
 Tests for Documents API endpoint in impress's core app: list
 """
+
 from unittest import mock
 
 import pytest

src/backend/core/tests/documents/test_api_documents_retrieve.py

@@ -1,6 +1,7 @@
 """
 Tests for Documents API endpoint in impress's core app: retrieve
 """
+
 import pytest
 from rest_framework.test import APIClient
 
@@ -228,6 +229,8 @@ def test_api_documents_retrieve_authenticated_related_team_members(
     factories.TeamDocumentAccessFactory()
 
     response = client.get(f"/api/v1.0/documents/{document.id!s}/")
+
+    # pylint: disable=R0801
     assert response.status_code == 200
     content = response.json()
     expected_abilities = {

src/backend/core/tests/documents/test_api_documents_update.py

@@ -1,6 +1,7 @@
 """
 Tests for Documents API endpoint in impress's core app: update
 """
+
 import random
 
 import pytest

src/backend/core/tests/swagger/test_openapi_schema.py

@@ -1,6 +1,7 @@
 """
 Test suite for generated openapi schema.
 """
+
 import json
 from io import StringIO
 

src/backend/core/tests/templates/test_api_templates_create.py

@@ -1,6 +1,7 @@
 """
 Tests for Templates API endpoint in impress's core app: create
 """
+
 import pytest
 from rest_framework.test import APIClient
 

src/backend/core/tests/templates/test_api_templates_delete.py

@@ -1,6 +1,7 @@
 """
 Tests for Templates API endpoint in impress's core app: delete
 """
+
 import random
 
 import pytest

src/backend/core/tests/templates/test_api_templates_generate_document.py

@@ -1,6 +1,7 @@
 """
 Test users API endpoints in the impress core app.
 """
+
 import pytest
 from rest_framework.test import APIClient
 
@@ -97,7 +98,7 @@ def test_api_templates_generate_document_related(via, mock_user_get_teams):
 
     client = APIClient()
     client.force_login(user)
-
+    access = None
     if via == USER:
         access = factories.UserTemplateAccessFactory(user=user)
     elif via == TEAM:

src/backend/core/tests/templates/test_api_templates_list.py

@@ -1,6 +1,7 @@
 """
 Tests for Templates API endpoint in impress's core app: list
 """
+
 from unittest import mock
 
 import pytest

src/backend/core/tests/templates/test_api_templates_retrieve.py

@@ -1,6 +1,7 @@
 """
 Tests for Templates API endpoint in impress's core app: retrieve
 """
+
 import pytest
 from rest_framework.test import APIClient
 

src/backend/core/tests/templates/test_api_templates_update.py

@@ -1,6 +1,7 @@
 """
 Tests for Templates API endpoint in impress's core app: update
 """
+
 import random
 
 import pytest

src/backend/core/tests/test_api_template_accesses.py

@@ -1,6 +1,7 @@
 """
 Test template accesses API endpoints for users in impress's core app.
 """
+
 import random
 from uuid import uuid4
 
@@ -67,6 +68,7 @@ def test_api_template_accesses_list_authenticated_related(via, mock_user_get_tea
     client.force_login(user)
 
     template = factories.TemplateFactory()
+    user_access = None
     if via == USER:
         user_access = models.TemplateAccess.objects.create(
             template=template,
@@ -733,6 +735,7 @@ def test_api_template_accesses_update_owner_self(via, mock_user_get_teams):
     client.force_login(user)
 
     template = factories.TemplateFactory()
+    access = None
     if via == USER:
         access = factories.UserTemplateAccessFactory(
             template=template, user=user, role="owner"
@@ -957,6 +960,7 @@ def test_api_template_accesses_delete_owners_last_owner(via, mock_user_get_teams
     client.force_login(user)
 
     template = factories.TemplateFactory()
+    access = None
     if via == USER:
         access = factories.UserTemplateAccessFactory(
             template=template, user=user, role="owner"

src/backend/core/tests/test_api_users.py

@@ -1,6 +1,7 @@
 """
 Test users API endpoints in the impress core app.
 """
+
 import pytest
 from rest_framework.test import APIClient
 

src/backend/core/tests/test_models_document_accesses.py

@@ -1,6 +1,7 @@
 """
 Unit tests for the DocumentAccess model
 """
+
 from django.contrib.auth.models import AnonymousUser
 from django.core.exceptions import ValidationError
 
@@ -318,7 +319,7 @@ def test_models_document_access_get_abilities_for_editor_of_administrator():
 
 
 def test_models_document_access_get_abilities_for_editor_of_editor_user(
-    django_assert_num_queries
+    django_assert_num_queries,
 ):
     """Check abilities of editor access for the editor of a document."""
     access = factories.UserDocumentAccessFactory(role="editor")
@@ -377,7 +378,7 @@ def test_models_document_access_get_abilities_for_reader_of_administrator():
 
 
 def test_models_document_access_get_abilities_for_reader_of_reader_user(
-    django_assert_num_queries
+    django_assert_num_queries,
 ):
     """Check abilities of reader access for the reader of a document."""
     access = factories.UserDocumentAccessFactory(role="reader")

src/backend/core/tests/test_models_documents.py

@@ -1,6 +1,7 @@
 """
 Unit tests for the Document model
 """
+
 from django.contrib.auth.models import AnonymousUser
 from django.core.exceptions import ValidationError
 from django.core.files.storage import default_storage

src/backend/core/tests/test_models_invitations.py

@@ -1,6 +1,7 @@
 """
 Unit tests for the Invitation model
 """
+
 import time
 
 from django.contrib.auth.models import AnonymousUser

src/backend/core/tests/test_models_template_accesses.py

@@ -1,6 +1,7 @@
 """
 Unit tests for the TemplateAccess model
 """
+
 from django.contrib.auth.models import AnonymousUser
 from django.core.exceptions import ValidationError
 
@@ -318,7 +319,7 @@ def test_models_template_access_get_abilities_for_editor_of_administrator():
 
 
 def test_models_template_access_get_abilities_for_editor_of_editor_user(
-    django_assert_num_queries
+    django_assert_num_queries,
 ):
     """Check abilities of editor access for the editor of a template."""
     access = factories.UserTemplateAccessFactory(role="editor")
@@ -377,7 +378,7 @@ def test_models_template_access_get_abilities_for_reader_of_administrator():
 
 
 def test_models_template_access_get_abilities_for_reader_of_reader_user(
-    django_assert_num_queries
+    django_assert_num_queries,
 ):
     """Check abilities of reader access for the reader of a template."""
     access = factories.UserTemplateAccessFactory(role="reader")

src/backend/core/tests/test_models_templates.py

@@ -1,6 +1,7 @@
 """
 Unit tests for the Template model
 """
+
 from django.contrib.auth.models import AnonymousUser
 from django.core.exceptions import ValidationError
 

src/backend/core/tests/test_models_users.py

@@ -1,6 +1,7 @@
 """
 Unit tests for the User model
 """
+
 from unittest import mock
 
 from django.core.exceptions import ValidationError

src/backend/core/tests/test_utils.py

@@ -1,6 +1,7 @@
 """
 Unit tests for the Invitation model
 """
+
 import smtplib
 from logging import Logger
 from unittest import mock