From adb15dedb81fe187655f773d56ecf3bb00eca021 Mon Sep 17 00:00:00 2001
From: Anthony LC <anthony.le-courric@mail.numerique.gouv.fr>
Date: Wed, 2 Apr 2025 15:25:31 +0200
Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F(frontend)=20reduce=20props?=
 =?UTF-8?q?=20drilling?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Reduce proprs drilling
- Improve state rerendering with useIsCollaborativeEditable
---
 .../docs/doc-editor/components/DocEditor.tsx         |  6 +-----
 .../features/docs/doc-header/components/DocTitle.tsx | 12 +++++-------
 .../docs/doc-header/components/DocVersionHeader.tsx  |  8 ++------
 3 files changed, 8 insertions(+), 18 deletions(-)

diff --git a/src/frontend/apps/impress/src/features/docs/doc-editor/components/DocEditor.tsx b/src/frontend/apps/impress/src/features/docs/doc-editor/components/DocEditor.tsx
index 00be0a91..803d0a3d 100644
--- a/src/frontend/apps/impress/src/features/docs/doc-editor/components/DocEditor.tsx
+++ b/src/frontend/apps/impress/src/features/docs/doc-editor/components/DocEditor.tsx
@@ -54,11 +54,7 @@ export const DocEditor = ({ doc, versionId }: DocEditorProps) => {
           $padding={{ horizontal: isDesktop ? '54px' : 'base' }}
           className="--docs--doc-editor-header"
         >
-          {isVersion ? (
-            <DocVersionHeader title={doc.title} />
-          ) : (
-            <DocHeader doc={doc} />
-          )}
+          {isVersion ? <DocVersionHeader /> : <DocHeader doc={doc} />}
         </Box>
 
         <Box
diff --git a/src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx b/src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
index 5175cfe7..4d53835a 100644
--- a/src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
+++ b/src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
@@ -13,6 +13,7 @@ import {
   KEY_DOC,
   KEY_LIST_DOC,
   KEY_SUB_PAGE,
+  useDocStore,
   useTrans,
   useUpdateDoc,
 } from '@/docs/doc-management';
@@ -24,18 +25,15 @@ interface DocTitleProps {
 
 export const DocTitle = ({ doc }: DocTitleProps) => {
   if (!doc.abilities.partial_update) {
-    return <DocTitleText title={doc.title} />;
+    return <DocTitleText />;
   }
 
   return <DocTitleInput doc={doc} />;
 };
 
-interface DocTitleTextProps {
-  title?: string;
-}
-
-export const DocTitleText = ({ title }: DocTitleTextProps) => {
+export const DocTitleText = () => {
   const { isMobile } = useResponsiveStore();
+  const { currentDoc } = useDocStore();
   const { untitledDocument } = useTrans();
 
   return (
@@ -45,7 +43,7 @@ export const DocTitleText = ({ title }: DocTitleTextProps) => {
       $size={isMobile ? 'h4' : 'h2'}
       $variation="1000"
     >
-      {title || untitledDocument}
+      {currentDoc?.title || untitledDocument}
     </Text>
   );
 };
diff --git a/src/frontend/apps/impress/src/features/docs/doc-header/components/DocVersionHeader.tsx b/src/frontend/apps/impress/src/features/docs/doc-header/components/DocVersionHeader.tsx
index fd8e9199..511b803c 100644
--- a/src/frontend/apps/impress/src/features/docs/doc-header/components/DocVersionHeader.tsx
+++ b/src/frontend/apps/impress/src/features/docs/doc-header/components/DocVersionHeader.tsx
@@ -5,11 +5,7 @@ import { useCunninghamTheme } from '@/cunningham';
 
 import { DocTitleText } from './DocTitle';
 
-interface DocVersionHeaderProps {
-  title?: string;
-}
-
-export const DocVersionHeader = ({ title }: DocVersionHeaderProps) => {
+export const DocVersionHeader = () => {
   const { spacingsTokens } = useCunninghamTheme();
 
   const { t } = useTranslation();
@@ -23,7 +19,7 @@ export const DocVersionHeader = ({ title }: DocVersionHeaderProps) => {
         aria-label={t('It is the document title')}
         className="--docs--doc-version-header"
       >
-        <DocTitleText title={title} />
+        <DocTitleText />
         <HorizontalSeparator />
       </Box>
     </>