From cdea75b87ff0d4722d07799eb7b936a7b6aaac9d Mon Sep 17 00:00:00 2001 From: Anthony LC Date: Tue, 17 Dec 2024 09:50:16 +0100 Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=EF=B8=8F(ci)=20playwright=20install?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sometimes Playwwright installation fails on CI, it seems to arrive when we update the dependency cache. We will do a general install before installing the playwright browser to be sure everything is in place, it should be fast since we have the cache. We move the playwright installation before setting the docker container, so we will wait less if we have to retry the test because of the Playwwright installation. --- .github/workflows/impress-frontend.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/impress-frontend.yml b/.github/workflows/impress-frontend.yml index 8e0ac0b6..5b35f9c8 100644 --- a/.github/workflows/impress-frontend.yml +++ b/.github/workflows/impress-frontend.yml @@ -95,12 +95,12 @@ jobs: - name: Set e2e env variables run: cat env.d/development/common.e2e.dist >> env.d/development/common.dist + - name: Install Playwright Browsers + run: cd src/frontend/apps/e2e && yarn install --frozen-lockfile && yarn install-playwright chromium + - name: Start Docker services run: make bootstrap FLUSH_ARGS='--no-input' cache= - - name: Install Playwright Browsers - run: cd src/frontend/apps/e2e && yarn install-playwright chromium - # Tool to wait for a service to be ready - name: Install Dockerize run: | @@ -151,12 +151,12 @@ jobs: - name: Set e2e env variables run: cat env.d/development/common.e2e.dist >> env.d/development/common.dist + - name: Install Playwright Browsers + run: cd src/frontend/apps/e2e && yarn install --frozen-lockfile && yarn install-playwright firefox webkit + - name: Start Docker services run: make bootstrap FLUSH_ARGS='--no-input' cache= - - name: Install Playwright Browsers - run: cd src/frontend/apps/e2e && yarn install-playwright firefox webkit chromium - - name: Run e2e tests run: cd src/frontend/ && yarn e2e:test --project=firefox --project=webkit