From e4aa85be83298be449602c750ca57b575167f661 Mon Sep 17 00:00:00 2001
From: Anthony LC <anthony.le-courric@mail.numerique.gouv.fr>
Date: Thu, 18 Sep 2025 11:28:20 +0200
Subject: [PATCH] =?UTF-8?q?=E2=9C=85(e2e)=20fix=20flakiness?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Some tests were getting very flaky due to previous
tests updates. This should fix it.
---
 .../apps/e2e/__tests__/app-impress/doc-header.spec.ts    | 4 +++-
 .../apps/e2e/__tests__/app-impress/utils-share.ts        | 9 ++++++---
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts
index ef416fb9..6540d54c 100644
--- a/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts
@@ -438,7 +438,9 @@ test.describe('Doc Header', () => {
 
     // Pin
     await page.getByText('push_pin').click();
-    await page.getByLabel('Open the document options').click();
+    await page
+      .getByRole('button', { name: 'Open the document options' })
+      .click();
     await expect(page.getByText('Unpin')).toBeVisible();
 
     await page.goto('/');
diff --git a/src/frontend/apps/e2e/__tests__/app-impress/utils-share.ts b/src/frontend/apps/e2e/__tests__/app-impress/utils-share.ts
index 5fe90a48..5c2a5a33 100644
--- a/src/frontend/apps/e2e/__tests__/app-impress/utils-share.ts
+++ b/src/frontend/apps/e2e/__tests__/app-impress/utils-share.ts
@@ -113,9 +113,12 @@ export const connectOtherUserToDoc = async (
   const otherPage = await otherContext.newPage();
   await otherPage.goto(docUrl);
 
-  await otherPage.getByRole('button', { name: 'Login' }).click({
-    timeout: 15000,
-  });
+  await otherPage
+    .getByRole('main', { name: 'Main content' })
+    .getByLabel('Login')
+    .click({
+      timeout: 15000,
+    });
 
   await keyCloakSignIn(otherPage, otherBrowserName, false);