From f2e54308d2985750ebab782b2b7178d8e5c5cea8 Mon Sep 17 00:00:00 2001 From: Richard Jones Date: Fri, 18 Apr 2025 13:41:34 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(helm)=20charts=20generate=20invali?= =?UTF-8?q?d=20YAML=20for=20collaboration=20API=20/=20WS?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Closes #890 Remove the service blocks outside the conditionals in the collaboration API and WS templates. Signed-off-by: Richard Jones --- CHANGELOG.md | 5 ++++- src/helm/impress/templates/ingress_collaboration_api.yaml | 4 ---- src/helm/impress/templates/ingress_collaboration_ws.yaml | 4 ---- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cf9e052d..9e6087d4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,10 @@ and this project adheres to ## [Unreleased] +## Fixed + +- 🐛(helm) charts generate invalid YAML for collaboration API / WS #890 + ## [3.4.2] - 2025-07-18 ### Changed @@ -141,7 +145,6 @@ and this project adheres to - 🐛(backend) race condition create doc #633 - 🐛(frontend) fix breaklines in custom blocks #908 - ## [3.1.0] - 2025-04-07 ## Added diff --git a/src/helm/impress/templates/ingress_collaboration_api.yaml b/src/helm/impress/templates/ingress_collaboration_api.yaml index f4dc92ef..30d63279 100644 --- a/src/helm/impress/templates/ingress_collaboration_api.yaml +++ b/src/helm/impress/templates/ingress_collaboration_api.yaml @@ -51,10 +51,6 @@ spec: pathType: ImplementationSpecific {{- end }} backend: - service: - name: {{ include "impress.yProvider.fullname" . }} - port: - number: {{ .Values.yProvider.service.port }} {{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }} service: name: {{ include "impress.yProvider.fullname" . }} diff --git a/src/helm/impress/templates/ingress_collaboration_ws.yaml b/src/helm/impress/templates/ingress_collaboration_ws.yaml index 6bd4325e..887f74dd 100644 --- a/src/helm/impress/templates/ingress_collaboration_ws.yaml +++ b/src/helm/impress/templates/ingress_collaboration_ws.yaml @@ -51,10 +51,6 @@ spec: pathType: ImplementationSpecific {{- end }} backend: - service: - name: {{ include "impress.yProvider.fullname" . }} - port: - number: {{ .Values.yProvider.service.port }} {{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }} service: name: {{ include "impress.yProvider.fullname" . }}