From f9f32db854fe3d7c8348530d410b285134668a43 Mon Sep 17 00:00:00 2001 From: Anto59290 Date: Tue, 13 Jan 2026 19:47:25 +0100 Subject: [PATCH] =?UTF-8?q?=E2=9C=85(e2e)=20fix=20e2e=20test=20for=20other?= =?UTF-8?q?=20browsers?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In this test the comment is made using the "current" browser which can be Chromium but can also be Firefox or Webkit. This is why the test failed with other browsers. Signed-off-by: Anto59290 --- CHANGELOG.md | 4 ++++ .../apps/e2e/__tests__/app-impress/doc-comments.spec.ts | 2 +- .../e2e/__tests__/app-impress/doc-inherited-share.spec.ts | 2 +- src/frontend/apps/e2e/__tests__/app-impress/utils-common.ts | 4 +++- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f6390107..68305f62 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ and this project adheres to ## [Unreleased] +### Fixed + +- ✅(e2e) fix e2e test for other browsers #1799 + ## [4.4.0] - 2026-01-13 ### Added diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-comments.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-comments.spec.ts index 665a9f7a..b73814b4 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-comments.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-comments.spec.ts @@ -58,7 +58,7 @@ test.describe('Doc Comments', () => { await page.getByRole('button', { name: '👍' }).click(); await expect( - thread.getByRole('img', { name: 'E2E Chromium' }).first(), + thread.getByRole('img', { name: `E2E ${browserName}` }).first(), ).toBeVisible(); await expect(thread.getByText('This is a comment').first()).toBeVisible(); await expect(thread.getByText(`E2E ${browserName}`).first()).toBeVisible(); diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-inherited-share.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-inherited-share.spec.ts index efc19da6..7ad02d31 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/doc-inherited-share.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-inherited-share.spec.ts @@ -21,7 +21,7 @@ test.describe('Inherited share accesses', () => { `doc-share-member-row-user.test@${browserName}.test`, ); await expect(user).toBeVisible(); - await expect(user.getByText('E2E Chromium')).toBeVisible(); + await expect(user.getByText(`E2E ${browserName}`)).toBeVisible(); await expect(user.getByText('Owner')).toBeVisible(); await page diff --git a/src/frontend/apps/e2e/__tests__/app-impress/utils-common.ts b/src/frontend/apps/e2e/__tests__/app-impress/utils-common.ts index 67adf44c..da4a722d 100644 --- a/src/frontend/apps/e2e/__tests__/app-impress/utils-common.ts +++ b/src/frontend/apps/e2e/__tests__/app-impress/utils-common.ts @@ -224,7 +224,9 @@ export const updateDocTitle = async (page: Page, title: string) => { await expect(input).toHaveText(''); await expect(input).toBeVisible(); await input.click(); - await input.fill(title); + await input.fill(title, { + force: true, + }); await input.click(); await input.blur(); await verifyDocName(page, title);