Enable @typescript-eslint/consistent-type-imports lint rule (#2886)

* Enable @typescript-eslint/consistent-type-imports lint rule

This is to help ensure that we get proper vite/rollup lazy loading by not `import`ing more than we need to.

Revert "Enable @typescript-eslint/consistent-type-imports lint rule"

This reverts commit ba385fa00b7e410cc508fd5fb9fe972233ae114f.

Enable @typescript-eslint/consistent-type-imports lint rule

This is to help ensure that we get proper vite/rollup lazy loading by not `import`ing more than we need to.

.

* Format

src/state/CallViewModel.test.ts

@@ -11,23 +11,26 @@ import {
   debounceTime,
   distinctUntilChanged,
   map,
-  Observable,
+  type Observable,
   of,
   switchMap,
 } from "rxjs";
-import { MatrixClient } from "matrix-js-sdk/src/matrix";
+import { type MatrixClient } from "matrix-js-sdk/src/matrix";
 import {
   ConnectionState,
-  LocalParticipant,
-  Participant,
+  type LocalParticipant,
+  type Participant,
   ParticipantEvent,
-  RemoteParticipant,
+  type RemoteParticipant,
 } from "livekit-client";
 import * as ComponentsCore from "@livekit/components-core";
 import { isEqual } from "lodash-es";
-import { CallMembership, MatrixRTCSession } from "matrix-js-sdk/src/matrixrtc";
+import {
+  type CallMembership,
+  type MatrixRTCSession,
+} from "matrix-js-sdk/src/matrixrtc";
 
-import { CallViewModel, Layout } from "./CallViewModel";
+import { CallViewModel, type Layout } from "./CallViewModel";
 import {
   mockLivekitRoom,
   mockLocalParticipant,
@@ -40,7 +43,7 @@ import {
 } from "../utils/test";
 import {
   ECAddonConnectionState,
-  ECConnectionState,
+  type ECConnectionState,
 } from "../livekit/useECConnectionState";
 import { E2eeType } from "../e2ee/e2eeType";
 

src/state/CallViewModel.ts

@@ -11,18 +11,21 @@ import {
   observeParticipantMedia,
 } from "@livekit/components-core";
 import {
-  Room as LivekitRoom,
-  LocalParticipant,
+  type Room as LivekitRoom,
+  type LocalParticipant,
   LocalVideoTrack,
   ParticipantEvent,
-  RemoteParticipant,
+  type RemoteParticipant,
   Track,
 } from "livekit-client";
-import { Room as MatrixRoom, RoomMember } from "matrix-js-sdk/src/matrix";
+import {
+  type Room as MatrixRoom,
+  type RoomMember,
+} from "matrix-js-sdk/src/matrix";
 import {
   BehaviorSubject,
   EMPTY,
-  Observable,
+  type Observable,
   Subject,
   combineLatest,
   concat,
@@ -47,35 +50,38 @@ import {
 } from "rxjs";
 import { logger } from "matrix-js-sdk/src/logger";
 import {
-  MatrixRTCSession,
+  type MatrixRTCSession,
   MatrixRTCSessionEvent,
 } from "matrix-js-sdk/src/matrixrtc";
 
 import { ViewModel } from "./ViewModel";
 import {
   ECAddonConnectionState,
-  ECConnectionState,
+  type ECConnectionState,
 } from "../livekit/useECConnectionState";
 import {
   LocalUserMediaViewModel,
-  MediaViewModel,
+  type MediaViewModel,
   observeTrackReference,
   RemoteUserMediaViewModel,
   ScreenShareViewModel,
-  UserMediaViewModel,
+  type UserMediaViewModel,
 } from "./MediaViewModel";
 import { accumulate, finalizeValue } from "../utils/observable";
 import { ObservableScope } from "./ObservableScope";
 import { duplicateTiles } from "../settings/settings";
 import { isFirefox } from "../Platform";
 import { setPipEnabled } from "../controls";
-import { GridTileViewModel, SpotlightTileViewModel } from "./TileViewModel";
+import {
+  type GridTileViewModel,
+  type SpotlightTileViewModel,
+} from "./TileViewModel";
 import { TileStore } from "./TileStore";
 import { gridLikeLayout } from "./GridLikeLayout";
 import { spotlightExpandedLayout } from "./SpotlightExpandedLayout";
 import { oneOnOneLayout } from "./OneOnOneLayout";
 import { pipLayout } from "./PipLayout";
-import { EncryptionSystem } from "../e2ee/sharedKeyManagement";
+import { type EncryptionSystem } from "../e2ee/sharedKeyManagement";
 import { observeSpeaker } from "./observeSpeaker";
 
 // How long we wait after a focus switch before showing the real participant

src/state/GridLikeLayout.ts

@@ -5,9 +5,9 @@ SPDX-License-Identifier: AGPL-3.0-only
 Please see LICENSE in the repository root for full details.
 */
 
-import { Layout, LayoutMedia } from "./CallViewModel";
-import { TileStore } from "./TileStore";
-import { GridTileViewModel } from "./TileViewModel";
+import { type Layout, type LayoutMedia } from "./CallViewModel";
+import { type TileStore } from "./TileStore";
+import { type GridTileViewModel } from "./TileViewModel";
 
 export type GridLikeLayoutType =
   | "grid"

src/state/MediaViewModel.ts

@@ -6,30 +6,30 @@ Please see LICENSE in the repository root for full details.
 */
 
 import {
-  AudioSource,
-  TrackReferenceOrPlaceholder,
-  VideoSource,
+  type AudioSource,
+  type TrackReferenceOrPlaceholder,
+  type VideoSource,
   observeParticipantEvents,
   observeParticipantMedia,
   roomEventSelector,
 } from "@livekit/components-core";
 import {
-  LocalParticipant,
+  type LocalParticipant,
   LocalTrack,
-  Participant,
+  type Participant,
   ParticipantEvent,
-  RemoteParticipant,
+  type RemoteParticipant,
   Track,
   TrackEvent,
   facingModeFromLocalTrack,
-  Room as LivekitRoom,
+  type Room as LivekitRoom,
   RoomEvent as LivekitRoomEvent,
   RemoteTrack,
 } from "livekit-client";
-import { RoomMember, RoomMemberEvent } from "matrix-js-sdk/src/matrix";
+import { type RoomMember, RoomMemberEvent } from "matrix-js-sdk/src/matrix";
 import {
   BehaviorSubject,
-  Observable,
+  type Observable,
   Subject,
   combineLatest,
   distinctUntilKeyChanged,
@@ -49,7 +49,7 @@ import { ViewModel } from "./ViewModel";
 import { useReactiveState } from "../useReactiveState";
 import { alwaysShowSelf } from "../settings/settings";
 import { accumulate } from "../utils/observable";
-import { EncryptionSystem } from "../e2ee/sharedKeyManagement";
+import { type EncryptionSystem } from "../e2ee/sharedKeyManagement";
 import { E2eeType } from "../e2ee/e2eeType";
 
 // TODO: Move this naming logic into the view model

src/state/ObservableScope.ts

@@ -7,7 +7,7 @@ Please see LICENSE in the repository root for full details.
 
 import {
   distinctUntilChanged,
-  Observable,
+  type Observable,
   shareReplay,
   Subject,
   takeUntil,

src/state/OneOnOneLayout.ts

@@ -5,9 +5,9 @@ SPDX-License-Identifier: AGPL-3.0-only
 Please see LICENSE in the repository root for full details.
 */
 
-import { OneOnOneLayout, OneOnOneLayoutMedia } from "./CallViewModel";
-import { TileStore } from "./TileStore";
-import { GridTileViewModel } from "./TileViewModel";
+import { type OneOnOneLayout, type OneOnOneLayoutMedia } from "./CallViewModel";
+import { type TileStore } from "./TileStore";
+import { type GridTileViewModel } from "./TileViewModel";
 
 /**
  * Produces a one-on-one layout with the given media.

src/state/PipLayout.ts

@@ -5,9 +5,9 @@ SPDX-License-Identifier: AGPL-3.0-only
 Please see LICENSE in the repository root for full details.
 */
 
-import { PipLayout, PipLayoutMedia } from "./CallViewModel";
-import { TileStore } from "./TileStore";
-import { GridTileViewModel } from "./TileViewModel";
+import { type PipLayout, type PipLayoutMedia } from "./CallViewModel";
+import { type TileStore } from "./TileStore";
+import { type GridTileViewModel } from "./TileViewModel";
 
 /**
  * Produces a picture-in-picture layout with the given media.

src/state/SpotlightExpandedLayout.ts

@@ -6,11 +6,11 @@ Please see LICENSE in the repository root for full details.
 */
 
 import {
-  SpotlightExpandedLayout,
-  SpotlightExpandedLayoutMedia,
+  type SpotlightExpandedLayout,
+  type SpotlightExpandedLayoutMedia,
 } from "./CallViewModel";
-import { TileStore } from "./TileStore";
-import { GridTileViewModel } from "./TileViewModel";
+import { type TileStore } from "./TileStore";
+import { type GridTileViewModel } from "./TileViewModel";
 
 /**
  * Produces an expanded spotlight layout with the given media.

src/state/TileStore.ts

@@ -7,7 +7,7 @@ Please see LICENSE in the repository root for full details.
 
 import { BehaviorSubject } from "rxjs";
 
-import { MediaViewModel, UserMediaViewModel } from "./MediaViewModel";
+import { type MediaViewModel, type UserMediaViewModel } from "./MediaViewModel";
 import { GridTileViewModel, SpotlightTileViewModel } from "./TileViewModel";
 import { fillGaps } from "../utils/iter";
 

src/state/TileViewModel.ts

@@ -5,10 +5,10 @@ SPDX-License-Identifier: AGPL-3.0-only
 Please see LICENSE in the repository root for full details.
 */
 
-import { BehaviorSubject, Observable } from "rxjs";
+import { BehaviorSubject, type Observable } from "rxjs";
 
 import { ViewModel } from "./ViewModel";
-import { MediaViewModel, UserMediaViewModel } from "./MediaViewModel";
+import { type MediaViewModel, type UserMediaViewModel } from "./MediaViewModel";
 
 let nextId = 0;
 function createId(): string {

src/state/observeSpeaker.ts

@@ -5,7 +5,7 @@ SPDX-License-Identifier: AGPL-3.0-only
 Please see LICENSE in the repository root for full details.
 */
 import {
-  Observable,
+  type Observable,
   audit,
   merge,
   timer,