Only forbid using console in application code

This commit is contained in:
Robin
2025-08-14 14:57:20 +02:00
parent 02f9d0822f
commit 217fa40ddb
2 changed files with 11 additions and 4 deletions

View File

@@ -28,8 +28,6 @@ module.exports = {
rules: { rules: {
"matrix-org/require-copyright-header": ["error", COPYRIGHT_HEADER], "matrix-org/require-copyright-header": ["error", COPYRIGHT_HEADER],
"jsx-a11y/media-has-caption": "off", "jsx-a11y/media-has-caption": "off",
// We should use the js-sdk logger, never console directly.
"no-console": ["error"],
"react/display-name": "error", "react/display-name": "error",
// Encourage proper usage of Promises: // Encourage proper usage of Promises:
"@typescript-eslint/no-floating-promises": "error", "@typescript-eslint/no-floating-promises": "error",
@@ -46,6 +44,15 @@ module.exports = {
"rxjs/no-exposed-subjects": "error", "rxjs/no-exposed-subjects": "error",
"rxjs/finnish": ["error", { names: { "^this$": false } }], "rxjs/finnish": ["error", { names: { "^this$": false } }],
}, },
overrides: [
{
files: ["src/*/**"],
rules: {
// In application code we should use the js-sdk logger, never console directly.
"no-console": ["error"],
},
},
],
settings: { settings: {
react: { react: {
version: "detect", version: "detect",

View File

@@ -18,7 +18,7 @@ import { sentryVitePlugin } from "@sentry/vite-plugin";
import react from "@vitejs/plugin-react"; import react from "@vitejs/plugin-react";
import { realpathSync } from "fs"; import { realpathSync } from "fs";
import * as fs from "node:fs"; import * as fs from "node:fs";
import { logger } from "matrix-js-sdk/lib/logger";
// https://vitejs.dev/config/ // https://vitejs.dev/config/
// Modified type helper from defineConfig to allow for packageType (see defineConfig from vite) // Modified type helper from defineConfig to allow for packageType (see defineConfig from vite)
export default ({ export default ({
@@ -86,7 +86,7 @@ export default ({
allow.push(realpathSync(path)); allow.push(realpathSync(path));
} catch {} } catch {}
} }
logger.log("Allowed vite paths:", allow); console.log("Allowed vite paths:", allow);
return { return {
server: { server: {