Actually fix the test flake

This commit is contained in:
Robin
2025-09-10 16:42:09 +02:00
parent 34a8977dd1
commit 32cb8541f4

View File

@@ -13,7 +13,7 @@ import {
test, test,
vi, vi,
} from "vitest"; } from "vitest";
import { render, waitFor, screen } from "@testing-library/react"; import { render, waitFor, screen, act } from "@testing-library/react";
import { type MatrixClient, JoinRule, type RoomState } from "matrix-js-sdk"; import { type MatrixClient, JoinRule, type RoomState } from "matrix-js-sdk";
import { import {
MatrixRTCSessionEvent, MatrixRTCSessionEvent,
@@ -22,7 +22,7 @@ import {
import { BrowserRouter } from "react-router-dom"; import { BrowserRouter } from "react-router-dom";
import userEvent from "@testing-library/user-event"; import userEvent from "@testing-library/user-event";
import { type RelationsContainer } from "matrix-js-sdk/lib/models/relations-container"; import { type RelationsContainer } from "matrix-js-sdk/lib/models/relations-container";
import { act, useState } from "react"; import { useState } from "react";
import { TooltipProvider } from "@vector-im/compound-web"; import { TooltipProvider } from "@vector-im/compound-web";
import { type MuteStates } from "./MuteStates"; import { type MuteStates } from "./MuteStates";
@@ -268,9 +268,12 @@ test("user can reconnect after a membership manager error", async () => {
await act(() => await act(() =>
rtcSession.emit(MatrixRTCSessionEvent.MembershipManagerError, undefined), rtcSession.emit(MatrixRTCSessionEvent.MembershipManagerError, undefined),
); );
await user.click(screen.getByRole("button", { name: "Reconnect" })); // XXX: Wrapping the following click in act() shouldn't be necessary (the
// async state update should be processed automatically by the waitFor call),
// and yet here we are.
await act(async () =>
user.click(screen.getByRole("button", { name: "Reconnect" })),
);
// In-call controls should be visible again // In-call controls should be visible again
await waitFor(() => screen.getByRole("button", { name: "Leave" }), { await waitFor(() => screen.getByRole("button", { name: "Leave" }));
timeout: 3000,
});
}); });