Fix react errors in settings tab (#3314)
* Fix react errors in settings tab * review
This commit is contained in:
@@ -57,7 +57,7 @@ export const FeedbackSettingsTab: FC<Props> = ({ roomId }) => {
|
|||||||
|
|
||||||
const [optInAnalytics, setOptInAnalytics] = useOptInAnalytics();
|
const [optInAnalytics, setOptInAnalytics] = useOptInAnalytics();
|
||||||
const optInDescription = (
|
const optInDescription = (
|
||||||
<Text size="sm">
|
<Text size="sm" as="span">
|
||||||
<Trans i18nKey="settings.opt_in_description">
|
<Trans i18nKey="settings.opt_in_description">
|
||||||
<AnalyticsNotice />
|
<AnalyticsNotice />
|
||||||
<br />
|
<br />
|
||||||
|
|||||||
@@ -36,6 +36,7 @@ export function TabContainer<K extends Key>({
|
|||||||
<NavBar role="tablist" aria-label={label} className={styles.tabList}>
|
<NavBar role="tablist" aria-label={label} className={styles.tabList}>
|
||||||
{tabs.map(({ key, name }) => (
|
{tabs.map(({ key, name }) => (
|
||||||
<NavItem
|
<NavItem
|
||||||
|
key={key}
|
||||||
aria-controls={`${idPrefix}[${key}]`}
|
aria-controls={`${idPrefix}[${key}]`}
|
||||||
onClick={() => onTabChange(key)}
|
onClick={() => onTabChange(key)}
|
||||||
active={key === tab}
|
active={key === tab}
|
||||||
@@ -46,6 +47,7 @@ export function TabContainer<K extends Key>({
|
|||||||
</NavBar>
|
</NavBar>
|
||||||
{tabs.map(({ key, content }) => (
|
{tabs.map(({ key, content }) => (
|
||||||
<div
|
<div
|
||||||
|
key={key}
|
||||||
id={`${idPrefix}[${key}]`}
|
id={`${idPrefix}[${key}]`}
|
||||||
style={{ display: key === tab ? undefined : "none" }}
|
style={{ display: key === tab ? undefined : "none" }}
|
||||||
>
|
>
|
||||||
|
|||||||
Reference in New Issue
Block a user