fix comments
This commit is contained in:
@@ -280,7 +280,7 @@ async function makeTransport(
|
|||||||
// - If we set it to the hased alias we get from the jwt, we will end up using the hashed alias as the body.roomId field
|
// - If we set it to the hased alias we get from the jwt, we will end up using the hashed alias as the body.roomId field
|
||||||
// in v0.16.0. (It will use oldest member transport. It is using the transport.livekit_alias as the body.roomId)
|
// in v0.16.0. (It will use oldest member transport. It is using the transport.livekit_alias as the body.roomId)
|
||||||
//
|
//
|
||||||
// TLDR this is a temporal fild that allow for comaptibilty but the spec expects it to not exists. (but its existance also does not break anything)
|
// TLDR this is a temporal field that allow for comaptibilty but the spec expects it to not exists. (but its existance also does not break anything)
|
||||||
// It is just named poorly: It was intetended to be the actual alias. But now we do pseudonymys ids so we use a hashed alias.
|
// It is just named poorly: It was intetended to be the actual alias. But now we do pseudonymys ids so we use a hashed alias.
|
||||||
livekit_alias: roomId,
|
livekit_alias: roomId,
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -148,6 +148,7 @@ export function areLivekitTransportsEqual<T extends LivekitTransport>(
|
|||||||
t1.livekit_service_url === t2.livekit_service_url &&
|
t1.livekit_service_url === t2.livekit_service_url &&
|
||||||
// In case we have different lk rooms in the same SFU (depends on the livekit authorization service)
|
// In case we have different lk rooms in the same SFU (depends on the livekit authorization service)
|
||||||
// It is only needed in case the livekit authorization service is not behaving as expected (or custom implementation)
|
// It is only needed in case the livekit authorization service is not behaving as expected (or custom implementation)
|
||||||
|
// Also LivekitTransport is planned to become a `ConnectionIdentifier` which moves this equal somewhere else.
|
||||||
t1.livekit_alias === t2.livekit_alias
|
t1.livekit_alias === t2.livekit_alias
|
||||||
);
|
);
|
||||||
if (!t1 && !t2) return true;
|
if (!t1 && !t2) return true;
|
||||||
|
|||||||
Reference in New Issue
Block a user