studio/element-call
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prove that the remote members modules only output remote members

Browse Source 
They had loose types that were allowing them also output local members. They don't do this, it's just misleading.
This commit is contained in:
Robin
2025-12-08 23:01:44 -05:00
parent cc8e250d96
commit 47cd343d44
4 changed files with 33 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/state/CallViewModel/remoteMembers/Connection.test.ts
View File

@@ -32,7 +32,6 @@ import {
Connection,
type ConnectionOpts,
type ConnectionState,
type PublishingParticipant,
} from "./Connection.ts";
import { ObservableScope } from "../../ObservableScope.ts";
import { type OpenIDClientParts } from "../../../livekit/openIDSFU.ts";
@@ -381,7 +380,7 @@ describe("Publishing participants observations", () => {
const bobIsAPublisher = Promise.withResolvers<void>();
const danIsAPublisher = Promise.withResolvers<void>();
const observedPublishers: PublishingParticipant[][] = [];
const observedPublishers: RemoteParticipant[][] = [];
const s = connection.remoteParticipantsWithTracks$.subscribe(
(publishers) => {
observedPublishers.push(publishers);
@@ -394,7 +393,7 @@ describe("Publishing participants observations", () => {
},
);
onTestFinished(() => s.unsubscribe());
// The publishingParticipants$ observable is derived from the current members of the
// The remoteParticipants$ observable is derived from the current members of the
// livekitRoom and the rtc membership in order to publish the members that are publishing
// on this connection.
@@ -436,7 +435,7 @@ describe("Publishing participants observations", () => {
const connection = setupRemoteConnection();
let observedPublishers: PublishingParticipant[][] = [];
let observedPublishers: RemoteParticipant[][] = [];
const s = connection.remoteParticipantsWithTracks$.subscribe(
(publishers) => {
observedPublishers.push(publishers);