code review: recoveryActionHandler should not be optional

src/room/GroupCallErrorBoundary.test.tsx

@@ -17,7 +17,10 @@ import {
 import { BrowserRouter } from "react-router-dom";
 import userEvent from "@testing-library/user-event";
 
-import { GroupCallErrorBoundary } from "./GroupCallErrorBoundary.tsx";
+import {
+  type CallErrorRecoveryAction,
+  GroupCallErrorBoundary,
+} from "./GroupCallErrorBoundary.tsx";
 import {
   ConnectionLostError,
   E2EENotSupportedError,
@@ -60,7 +63,10 @@ test.each([
     const onErrorMock = vi.fn();
     const { asFragment } = render(
       <BrowserRouter>
-        <GroupCallErrorBoundary onError={onErrorMock}>
+        <GroupCallErrorBoundary
+          onError={onErrorMock}
+          recoveryActionHandler={vi.fn()}
+        >
           <TestComponent />
         </GroupCallErrorBoundary>
       </BrowserRouter>,
@@ -85,14 +91,17 @@ test("should render the error page with link back to home", async () => {
   const onErrorMock = vi.fn();
   const { asFragment } = render(
     <BrowserRouter>
-      <GroupCallErrorBoundary onError={onErrorMock}>
+      <GroupCallErrorBoundary
+        onError={onErrorMock}
+        recoveryActionHandler={vi.fn()}
+      >
         <TestComponent />
       </GroupCallErrorBoundary>
     </BrowserRouter>,
   );
 
   await screen.findByText("Call is not supported");
-  expect(screen.getByText(/Domain: example.com/i)).toBeInTheDocument();
+  expect(screen.getByText(/Domain: example\.com/i)).toBeInTheDocument();
   expect(
     screen.getByText(/Error Code: MISSING_MATRIX_RTC_FOCUS/i),
   ).toBeInTheDocument();
@@ -105,39 +114,7 @@ test("should render the error page with link back to home", async () => {
   expect(asFragment()).toMatchSnapshot();
 });
 
-test("should have a reconnect button for ConnectionLostError", async () => {
-  const user = userEvent.setup();
-
-  const reconnectCallback = vi.fn();
-
-  const TestComponent = (): ReactNode => {
-    throw new ConnectionLostError();
-  };
-
-  const { asFragment } = render(
-    <BrowserRouter>
-      <GroupCallErrorBoundary
-        onError={vi.fn()}
-        recoveryActionHandler={reconnectCallback}
-      >
-        <TestComponent />
-      </GroupCallErrorBoundary>
-    </BrowserRouter>,
-  );
-
-  await screen.findByText("Connection lost");
-  await screen.findByRole("button", { name: "Reconnect" });
-  await screen.findByRole("button", { name: "Return to home screen" });
-
-  expect(asFragment()).toMatchSnapshot();
-
-  await user.click(screen.getByRole("button", { name: "Reconnect" }));
-
-  expect(reconnectCallback).toHaveBeenCalledOnce();
-  expect(reconnectCallback).toHaveBeenCalledWith("reconnect");
-});
-
-test("Action handling should reset error state", async () => {
+test("ConnectionLostError: Action handling should reset error state", async () => {
   const user = userEvent.setup();
 
   const TestComponent: FC<{ fail: boolean }> = ({ fail }): ReactNode => {
@@ -147,11 +124,17 @@ test("Action handling should reset error state", async () => {
     return <div>HELLO</div>;
   };
 
+  const reconnectCallbackSpy = vi.fn();
+
   const WrapComponent = (): ReactNode => {
     const [failState, setFailState] = useState(true);
-    const reconnectCallback = useCallback(() => {
-      setFailState(false);
-    }, [setFailState]);
+    const reconnectCallback = useCallback(
+      (action: CallErrorRecoveryAction) => {
+        reconnectCallbackSpy(action);
+        setFailState(false);
+      },
+      [setFailState],
+    );
 
     return (
       <BrowserRouter>
@@ -162,15 +145,22 @@ test("Action handling should reset error state", async () => {
     );
   };
 
-  render(<WrapComponent />);
+  const { asFragment } = render(<WrapComponent />);
 
   // Should fail first
   await screen.findByText("Connection lost");
+  await screen.findByRole("button", { name: "Reconnect" });
+  await screen.findByRole("button", { name: "Return to home screen" });
+
+  expect(asFragment()).toMatchSnapshot();
 
   await user.click(screen.getByRole("button", { name: "Reconnect" }));
 
   // reconnect should have reset the error, thus rendering should be ok
   await screen.findByText("HELLO");
+
+  expect(reconnectCallbackSpy).toHaveBeenCalledOnce();
+  expect(reconnectCallbackSpy).toHaveBeenCalledWith("reconnect");
 });
 
 describe("Rageshake button", () => {
@@ -187,7 +177,10 @@ describe("Rageshake button", () => {
 
     render(
       <BrowserRouter>
-        <GroupCallErrorBoundary onError={vi.fn()}>
+        <GroupCallErrorBoundary
+          onError={vi.fn()}
+          recoveryActionHandler={vi.fn()}
+        >
           <TestComponent />
         </GroupCallErrorBoundary>
       </BrowserRouter>,