Fixup: bad copy in the text

This commit is contained in:
Valere
2025-03-13 17:16:48 +01:00
parent 4c477bc4b1
commit 9dc515f45d
2 changed files with 20 additions and 5 deletions

View File

@@ -228,6 +228,25 @@ npx playwright codegen
This will record your action and write the test code for you. Use the tool bar to test visibility, text content, This will record your action and write the test code for you. Use the tool bar to test visibility, text content,
clicking.. clicking..
##### Investigate a failed test from the CI
In the failed action page, click on the failed job, then scroll down to the `upload-artifact` step.
You will find a link to download the zip report, as per:
```
Artifact playwright-report has been successfully uploaded! Final size is 1360358 bytes. Artifact ID is 2746265841
Artifact download URL: https://github.com/element-hq/element-call/actions/runs/13837660687/artifacts/2746265841
```
Unzip the report then use this command to open the report in your browser:
```shell
npx playwright show-report ~/Downloads/playwright-report/
```
Under the failed test there is a small icon looking like "3 columns" (next to test name file name),
click on it to see the live screenshots/console output.
### Test Coverage ### Test Coverage
<img src="https://codecov.io/github/element-hq/element-call/graphs/tree.svg?token=O6CFVKK6I1"></img> <img src="https://codecov.io/github/element-hq/element-call/graphs/tree.svg?token=O6CFVKK6I1"></img>

View File

@@ -46,13 +46,9 @@ test("Start a new call then leave and show the feedback screen", async ({
"John Doe, your call has ended. How did it go?", "John Doe, your call has ended. How did it go?",
); );
await expect(page.getByRole("main")).toContainText( await expect(page.getByRole("main")).toContainText(
"We'd love to hear your feedback so we can improve your experience.", "Why not finish by setting up a password to keep your account?",
); );
// Strange that the submit button test-id is home_go
await expect(page.getByTestId("home_go")).toBeVisible();
await expect(page.getByTestId("home_go")).toContainText("Submit");
await expect( await expect(
page.getByRole("link", { name: "Not now, return to home screen" }), page.getByRole("link", { name: "Not now, return to home screen" }),
).toBeVisible(); ).toBeVisible();