Elaborate on a TODO for preloading JWT tokens
This commit is contained in:
@@ -120,7 +120,6 @@ export class Connection {
|
|||||||
state: "FetchingConfig",
|
state: "FetchingConfig",
|
||||||
focus: this.localTransport,
|
focus: this.localTransport,
|
||||||
});
|
});
|
||||||
// TODO could this be loaded earlier to save time?
|
|
||||||
const { url, jwt } = await this.getSFUConfigWithOpenID();
|
const { url, jwt } = await this.getSFUConfigWithOpenID();
|
||||||
// If we were stopped while fetching the config, don't proceed to connect
|
// If we were stopped while fetching the config, don't proceed to connect
|
||||||
if (this.stopped) return;
|
if (this.stopped) return;
|
||||||
|
|||||||
@@ -105,6 +105,10 @@ export class PublishConnection extends Connection {
|
|||||||
// Observe mute state changes and update LiveKit microphone/camera states accordingly
|
// Observe mute state changes and update LiveKit microphone/camera states accordingly
|
||||||
this.observeMuteStates(this.scope);
|
this.observeMuteStates(this.scope);
|
||||||
|
|
||||||
|
// TODO: This will fetch the JWT token. Perhaps we could keep it preloaded
|
||||||
|
// instead? This optimization would only be safe for a publish connection,
|
||||||
|
// because we don't want to leak the user's intent to perhaps join a call to
|
||||||
|
// remote servers before they actually commit to it.
|
||||||
await super.start();
|
await super.start();
|
||||||
|
|
||||||
if (this.stopped) return;
|
if (this.stopped) return;
|
||||||
|
|||||||
Reference in New Issue
Block a user