From ab9dfc75f0dd5e1ce273a3825080d9158f59a96f Mon Sep 17 00:00:00 2001 From: Timo Date: Thu, 22 May 2025 13:04:42 +0200 Subject: [PATCH] Comment to explain the usage/impact of: `controlledMediaDevices` --- src/settings/SettingsModal.tsx | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/settings/SettingsModal.tsx b/src/settings/SettingsModal.tsx index 89402720..e0324188 100644 --- a/src/settings/SettingsModal.tsx +++ b/src/settings/SettingsModal.tsx @@ -104,10 +104,15 @@ export const SettingsModal: FC = ({ const [showDeveloperSettingsTab] = useSetting(developerMode); const { available: isRageshakeAvailable } = useSubmitRageshake(); + + // For controlled devices, we will not show the input section: + // Controlled media devices are used on mobile platforms, where input and output are grouped into + // a single device. These are called "headset" or "speaker" (or similar) but contain both input and output. + // On EC, we decided that it is less confusing for the user if they see those options in the output section + // rather than the input section. + const { controlledMediaDevices } = useUrlParams(); // If we are on iOS we will show a button to open the native audio device picker. const iosDeviceMenu = useObservableEagerState(iosDeviceMenu$); - // In controlled devices we will not show the input section - const { controlledMediaDevices } = useUrlParams(); const audioTab: Tab = { key: "audio",