studio/element-call
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crash during focus switching

Browse Source
This commit is contained in:
Robin
2025-10-14 09:29:48 -04:00
parent 392c51fbf6
commit b030d304df
1 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/state/PublishConnection.ts
View File

@@ -40,6 +40,8 @@ import { type ObservableScope } from "./ObservableScope.ts";
* This connection will publish the local user's audio and video tracks. * This connection will publish the local user's audio and video tracks.
*/ */
export class PublishConnection extends Connection { export class PublishConnection extends Connection {
private readonly scope: ObservableScope;
/** /**
* Creates a new PublishConnection. * Creates a new PublishConnection.
* @param args - The connection options. {@link ConnectionOpts} * @param args - The connection options. {@link ConnectionOpts}
@@ -75,11 +77,10 @@ export class PublishConnection extends Connection {
}); });
super(room, args); super(room, args);
this.scope = scope;
// Setup track processor syncing (blur) // Setup track processor syncing (blur)
this.observeTrackProcessors(scope, room, trackerProcessorState$); this.observeTrackProcessors(scope, room, trackerProcessorState$);
// Observe mute state changes and update LiveKit microphone/camera states accordingly
this.observeMuteStates(scope);
// Observe media device changes and update LiveKit active devices accordingly // Observe media device changes and update LiveKit active devices accordingly
this.observeMediaDevices(scope, devices, controlledAudioDevices); this.observeMediaDevices(scope, devices, controlledAudioDevices);
@@ -101,6 +102,9 @@ export class PublishConnection extends Connection {
public async start(): Promise<void> { public async start(): Promise<void> {
this.stopped = false; this.stopped = false;
// Observe mute state changes and update LiveKit microphone/camera states accordingly
this.observeMuteStates(this.scope);
await super.start(); await super.start();
if (this.stopped) return; if (this.stopped) return;
@@ -120,6 +124,14 @@ export class PublishConnection extends Connection {
} }
} }
public async stop(): Promise<void> {
// TODO-MULTI-SFU: Move these calls back to ObservableScope.onEnd once scope
// actually has the right lifetime
this.muteStates.audio.unsetHandler();
this.muteStates.video.unsetHandler();
await super.stop();
}
/// Private methods /// Private methods
// Restart the audio input track whenever we detect that the active media // Restart the audio input track whenever we detect that the active media
@@ -226,10 +238,6 @@ export class PublishConnection extends Connection {
} }
return this.livekitRoom.localParticipant.isCameraEnabled; return this.livekitRoom.localParticipant.isCameraEnabled;
}); });
scope.onEnd(() => {
this.muteStates.audio.unsetHandler();
this.muteStates.video.unsetHandler();
});
} }
private observeTrackProcessors( private observeTrackProcessors(