studio/element-call
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Never skip lobby for huddles (#3508)

Browse Source 
* Never skip lobby for huddles

Signed-off-by: Timo K <toger5@hotmail.de>

* tests

Signed-off-by: Timo K <toger5@hotmail.de>

---------

Signed-off-by: Timo K <toger5@hotmail.de>
This commit is contained in:
Timo
2025-09-22 11:35:20 +02:00
committed by GitHub
parent 9b9c08ed61
commit b2c594d36c
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/UrlParams.test.ts
View File

@@ -272,7 +272,7 @@ describe("UrlParams", () => {
computeUrlParams( computeUrlParams(
"?intent=start_call&widgetId=1234&parentUrl=parent.org", "?intent=start_call&widgetId=1234&parentUrl=parent.org",
), ),
).toMatchObject(startNewCallDefaults("desktop")); ).toMatchObject({ ...startNewCallDefaults("desktop"), skipLobby: false });
}); });
it("accepts start_call_dm mobile", () => { it("accepts start_call_dm mobile", () => {
@@ -320,12 +320,12 @@ describe("UrlParams", () => {
expect(computeUrlParams("?intent=start_call").skipLobby).toBe(false); expect(computeUrlParams("?intent=start_call").skipLobby).toBe(false);
}); });
it("defaults to true if intent is start_call in widget mode", () => { it("defaults to false if intent is start_call in widget mode", () => {
expect( expect(
computeUrlParams( computeUrlParams(
"?intent=start_call&widgetId=12345&parentUrl=https%3A%2F%2Flocalhost%2Ffoo", "?intent=start_call&widgetId=12345&parentUrl=https%3A%2F%2Flocalhost%2Ffoo",
).skipLobby, ).skipLobby,
).toBe(true); ).toBe(false);
}); });
it("default to false if intent is join_existing", () => { it("default to false if intent is join_existing", () => {

2
src/UrlParams.ts
View File

@@ -394,7 +394,7 @@ export const computeUrlParams = (search = "", hash = ""): UrlParams => {
}; };
switch (intent) { switch (intent) {
case UserIntent.StartNewCall: case UserIntent.StartNewCall:
intentPreset.skipLobby = true; intentPreset.skipLobby = false;
break; break;
case UserIntent.JoinExistingCall: case UserIntent.JoinExistingCall:
// On desktop this will be overridden based on which button was used to join the call // On desktop this will be overridden based on which button was used to join the call