From 03f6e6519bcccf4af8b9af292917818050d6c12a Mon Sep 17 00:00:00 2001
From: lebaudantoine <lebaud.antoine131@gmail.com>
Date: Fri, 31 Jan 2025 17:47:05 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=A9=B9(frontend)=20remove=20warning=20on?=
 =?UTF-8?q?=20modal=20without=20heading?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The MuteAlertDialog was triggering accessibility warnings, lacking
a proper heading. Fix it.
---
 .../features/rooms/livekit/components/MuteAlertDialog.tsx   | 6 +++++-
 src/frontend/src/locales/de/rooms.json                      | 1 +
 src/frontend/src/locales/en/rooms.json                      | 1 +
 src/frontend/src/locales/fr/rooms.json                      | 1 +
 4 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/frontend/src/features/rooms/livekit/components/MuteAlertDialog.tsx b/src/frontend/src/features/rooms/livekit/components/MuteAlertDialog.tsx
index 3a445092..815ea3ae 100644
--- a/src/frontend/src/features/rooms/livekit/components/MuteAlertDialog.tsx
+++ b/src/frontend/src/features/rooms/livekit/components/MuteAlertDialog.tsx
@@ -17,7 +17,11 @@ export const MuteAlertDialog = ({
     keyPrefix: 'participants.muteParticipantAlert',
   })
   return (
-    <Dialog isOpen={isOpen} role="alertdialog">
+    <Dialog
+      isOpen={isOpen}
+      role="alertdialog"
+      aria-label={t('heading', { name })}
+    >
       <P>{t('description', { name })}</P>
       <HStack gap={1}>
         <Button variant="text" size="sm" onPress={onClose}>
diff --git a/src/frontend/src/locales/de/rooms.json b/src/frontend/src/locales/de/rooms.json
index 3193aed6..cb91bff9 100644
--- a/src/frontend/src/locales/de/rooms.json
+++ b/src/frontend/src/locales/de/rooms.json
@@ -179,6 +179,7 @@
     "muteYourself": "",
     "muteParticipant": "",
     "muteParticipantAlert": {
+      "heading": "",
       "description": "",
       "confirm": "",
       "cancel": ""
diff --git a/src/frontend/src/locales/en/rooms.json b/src/frontend/src/locales/en/rooms.json
index 6aaf96b4..35fa94c7 100644
--- a/src/frontend/src/locales/en/rooms.json
+++ b/src/frontend/src/locales/en/rooms.json
@@ -178,6 +178,7 @@
     "muteYourself": "Close your mic",
     "muteParticipant": "Close the mic of {{name}}",
     "muteParticipantAlert": {
+      "heading": "Mute {{name}}",
       "description": "Mute {{name}} for all participants? {{name}} will be the only one who can unmute themselves.",
       "confirm": "Mute",
       "cancel": "Cancel"
diff --git a/src/frontend/src/locales/fr/rooms.json b/src/frontend/src/locales/fr/rooms.json
index 4e80b75e..80c20067 100644
--- a/src/frontend/src/locales/fr/rooms.json
+++ b/src/frontend/src/locales/fr/rooms.json
@@ -178,6 +178,7 @@
     "muteYourself": "Couper votre micro",
     "muteParticipant": "Couper le micro de {{name}}",
     "muteParticipantAlert": {
+      "heading": "Couper le micro de {{name}}",
       "description": "Couper le micro de {{name}} pour tous les participants ? {{name}} est la seule personne habilitée à réactiver son micro",
       "confirm": "Couper le micro",
       "cancel": "Annuler"