From 0c811222d49ac89a167891ef217be72f9b7d239b Mon Sep 17 00:00:00 2001
From: lebaudantoine <lebaud.antoine131@gmail.com>
Date: Mon, 28 Apr 2025 18:00:08 +0200
Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F(frontend)=20change=20Panel?=
 =?UTF-8?q?=20keepAlive=20default=20to=20false=20for=20all=20side=20panels?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Reverse default behavior for Panel component to unmount content from DOM when
closed instead of keeping it alive. Makes DOM updates more lightweight by
removing unused panel content. Improves performance particularly in complex
room with hundred of participants.

Exception made for chat panel which retains keepAlive=true to preserve
unsent messages that users may want to submit later.
---
 .../src/features/rooms/livekit/components/SidePanel.tsx       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/frontend/src/features/rooms/livekit/components/SidePanel.tsx b/src/frontend/src/features/rooms/livekit/components/SidePanel.tsx
index 4ee52e8f..2c80e2fe 100644
--- a/src/frontend/src/features/rooms/livekit/components/SidePanel.tsx
+++ b/src/frontend/src/features/rooms/livekit/components/SidePanel.tsx
@@ -113,7 +113,7 @@ type PanelProps = {
   keepAlive?: boolean
 }
 
-const Panel = ({ isOpen, keepAlive = true, children }: PanelProps) => (
+const Panel = ({ isOpen, keepAlive = false, children }: PanelProps) => (
   <div
     style={{
       display: isOpen ? 'inherit' : 'none',
@@ -161,7 +161,7 @@ export const SidePanel = () => {
       <Panel isOpen={isEffectsOpen}>
         <Effects />
       </Panel>
-      <Panel isOpen={isChatOpen}>
+      <Panel isOpen={isChatOpen} keepAlive={true}>
         <Chat />
       </Panel>
       <Panel isOpen={isToolsOpen}>