From 1a52221ef2096ff967f675e73918e32c47a864fa Mon Sep 17 00:00:00 2001 From: lebaudantoine Date: Fri, 11 Oct 2024 17:55:07 +0200 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F(frontend)=20remove=20depreca?= =?UTF-8?q?ted=20chat=20options?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Changes introduced by LiveKit which deprecated some chat's options. As we duplicated their code, let's just removed them. They are not useful, and not in use anywhere. --- .../src/features/rooms/livekit/prefabs/Chat.tsx | 14 ++------------ .../rooms/livekit/prefabs/VideoConference.tsx | 8 -------- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/src/frontend/src/features/rooms/livekit/prefabs/Chat.tsx b/src/frontend/src/features/rooms/livekit/prefabs/Chat.tsx index 7ea5b9ee..5b091628 100644 --- a/src/frontend/src/features/rooms/livekit/prefabs/Chat.tsx +++ b/src/frontend/src/features/rooms/livekit/prefabs/Chat.tsx @@ -30,21 +30,11 @@ export interface ChatProps * ``` * @public */ -export function Chat({ - messageFormatter, - messageDecoder, - messageEncoder, - channelTopic, - ...props -}: ChatProps) { +export function Chat({ messageFormatter, ...props }: ChatProps) { const inputRef = React.useRef(null) const ulRef = React.useRef(null) - const chatOptions: ChatOptions = React.useMemo(() => { - return { messageDecoder, messageEncoder, channelTopic } - }, [messageDecoder, messageEncoder, channelTopic]) - - const { send, chatMessages, isSending } = useChat(chatOptions) + const { send, chatMessages, isSending } = useChat() const layoutContext = useMaybeLayoutContext() const lastReadMsgAt = React.useRef(0) diff --git a/src/frontend/src/features/rooms/livekit/prefabs/VideoConference.tsx b/src/frontend/src/features/rooms/livekit/prefabs/VideoConference.tsx index 808e687c..71b2b51e 100644 --- a/src/frontend/src/features/rooms/livekit/prefabs/VideoConference.tsx +++ b/src/frontend/src/features/rooms/livekit/prefabs/VideoConference.tsx @@ -1,6 +1,4 @@ import type { - MessageDecoder, - MessageEncoder, TrackReferenceOrPlaceholder, WidgetState, } from '@livekit/components-core' @@ -55,8 +53,6 @@ const LayoutWrapper = styled( export interface VideoConferenceProps extends React.HTMLAttributes { chatMessageFormatter?: MessageFormatter - chatMessageEncoder?: MessageEncoder - chatMessageDecoder?: MessageDecoder /** @alpha */ SettingsComponent?: React.ComponentType } @@ -81,8 +77,6 @@ export interface VideoConferenceProps */ export function VideoConference({ chatMessageFormatter, - chatMessageDecoder, - chatMessageEncoder, ...props }: VideoConferenceProps) { const [widgetState, setWidgetState] = React.useState({ @@ -220,8 +214,6 @@ export function VideoConference({ {sidePanel && }