✨(project) add Room, Ressource, Access models from Magnify
I picked few models from Magnify to build our MVP: - Resource: A generic model representing any type of resource. Though currently used only by Room, it encapsulates a meaningful business logic as an abstract model. - Room: The primary object we manipulate, representing a meeting room with access and permission controls. - ResourceAccess Ensures relevant users have the appropriate permissions for a given room. ** What’s different from Magnify ? ** Removed group logic; it will be added later. For now, we rely on the user model's property to get its groups via desk. Removed any logic or method related to Jitsi or LiveKit. These servers will be integrated in the upcomming commits. Focus on Room-related models to maintain a minimal and functional product (KISS principle) until we achieve product-market fit (PMF). Creating simple public and private, permanent and temporary rooms is sufficient for building our MVP. The Meeting model in Magnify, which supports recurrence, should be handled by the collaborative calendar instead. Adapted the unit test to use Pytest, and linted all the sources using Ruff linter. (Migrations will be squashed before releasing the MVP)
This commit is contained in:
lebaudantoine
@@ -8,8 +8,10 @@ from django.conf import settings
|
||||
from django.contrib.auth import models as auth_models
|
||||
from django.contrib.auth.base_user import AbstractBaseUser
|
||||
from django.core import mail, validators
|
||||
from django.core.exceptions import PermissionDenied, ValidationError
|
||||
from django.db import models
|
||||
from django.utils.functional import lazy
|
||||
from django.utils.text import capfirst, slugify
|
||||
from django.utils.translation import gettext_lazy as _
|
||||
|
||||
from timezone_field import TimeZoneField
|
||||
@@ -17,6 +19,24 @@ from timezone_field import TimeZoneField
|
||||
logger = getLogger(__name__)
|
||||
|
||||
|
||||
class RoleChoices(models.TextChoices):
|
||||
"""Role choices."""
|
||||
|
||||
MEMBER = "member", _("Member")
|
||||
ADMIN = "administrator", _("Administrator")
|
||||
OWNER = "owner", _("Owner")
|
||||
|
||||
@classmethod
|
||||
def check_administrator_role(cls, role):
|
||||
"""Check if a role is administrator."""
|
||||
return role in [cls.ADMIN, cls.OWNER]
|
||||
|
||||
@classmethod
|
||||
def check_owner_role(cls, role):
|
||||
"""Check if a role is owner."""
|
||||
return role == cls.OWNER
|
||||
|
||||
|
||||
class BaseModel(models.Model):
|
||||
"""
|
||||
Serves as an abstract base model for other models, ensuring that records are validated
|
||||
@@ -141,3 +161,159 @@ class User(AbstractBaseUser, BaseModel, auth_models.PermissionsMixin):
|
||||
Must be cached if retrieved remotely.
|
||||
"""
|
||||
return []
|
||||
|
||||
|
||||
class Resource(BaseModel):
|
||||
"""Model to define access control"""
|
||||
|
||||
is_public = models.BooleanField(default=settings.DEFAULT_ROOM_IS_PUBLIC)
|
||||
users = models.ManyToManyField(
|
||||
User,
|
||||
through="ResourceAccess",
|
||||
through_fields=("resource", "user"),
|
||||
related_name="resources",
|
||||
)
|
||||
|
||||
class Meta:
|
||||
db_table = "impress_resource"
|
||||
verbose_name = _("Resource")
|
||||
verbose_name_plural = _("Resources")
|
||||
|
||||
def __str__(self):
|
||||
try:
|
||||
return self.name
|
||||
except AttributeError:
|
||||
return f"Resource {self.id!s}"
|
||||
|
||||
def get_role(self, user):
|
||||
"""
|
||||
Determine the role of a given user in this resource.
|
||||
"""
|
||||
if not user or not user.is_authenticated:
|
||||
return None
|
||||
|
||||
role = None
|
||||
for access in self.accesses.filter(user=user):
|
||||
if access.role == RoleChoices.OWNER:
|
||||
return RoleChoices.OWNER
|
||||
if access.role == RoleChoices.ADMIN:
|
||||
role = RoleChoices.ADMIN
|
||||
if access.role == RoleChoices.MEMBER and role != RoleChoices.ADMIN:
|
||||
role = RoleChoices.MEMBER
|
||||
return role
|
||||
|
||||
def is_administrator(self, user):
|
||||
"""
|
||||
Check if a user is administrator of the resource.
|
||||
|
||||
Users carrying the "owner" role are considered as administrators a fortiori.
|
||||
"""
|
||||
return RoleChoices.check_administrator_role(self.get_role(user))
|
||||
|
||||
def is_owner(self, user):
|
||||
"""Check if a user is owner of the resource."""
|
||||
return RoleChoices.check_owner_role(self.get_role(user))
|
||||
|
||||
|
||||
class ResourceAccess(BaseModel):
|
||||
"""Link table between resources and users"""
|
||||
|
||||
resource = models.ForeignKey(
|
||||
Resource,
|
||||
on_delete=models.CASCADE,
|
||||
related_name="accesses",
|
||||
)
|
||||
user = models.ForeignKey(User, on_delete=models.CASCADE, related_name="accesses")
|
||||
role = models.CharField(
|
||||
max_length=20, choices=RoleChoices.choices, default=RoleChoices.MEMBER
|
||||
)
|
||||
|
||||
class Meta:
|
||||
db_table = "impress_resource_access"
|
||||
verbose_name = _("Resource access")
|
||||
verbose_name_plural = _("Resource accesses")
|
||||
constraints = [
|
||||
models.UniqueConstraint(
|
||||
fields=["user", "resource"],
|
||||
name="resource_access_unique_user_resource",
|
||||
violation_error_message=_(
|
||||
"Resource access with this User and Resource already exists."
|
||||
),
|
||||
),
|
||||
]
|
||||
|
||||
def __str__(self):
|
||||
role = capfirst(self.get_role_display())
|
||||
try:
|
||||
resource = self.resource.name
|
||||
except AttributeError:
|
||||
resource = f"resource {self.resource_id!s}"
|
||||
|
||||
return f"{role:s} role for {self.user!s} on {resource:s}"
|
||||
|
||||
def save(self, *args, **kwargs):
|
||||
"""Make sure we keep at least one owner for the resource."""
|
||||
if self.pk and self.role != RoleChoices.OWNER:
|
||||
accesses = self._meta.model.objects.filter(
|
||||
resource=self.resource, role=RoleChoices.OWNER
|
||||
).only("pk")
|
||||
if len(accesses) == 1 and accesses[0].pk == self.pk:
|
||||
raise PermissionDenied("A resource should keep at least one owner.")
|
||||
return super().save(*args, **kwargs)
|
||||
|
||||
def delete(self, *args, **kwargs):
|
||||
"""Disallow deleting the last of the Mohicans."""
|
||||
if (
|
||||
self.role == RoleChoices.OWNER
|
||||
and self._meta.model.objects.filter(
|
||||
resource=self.resource, role=RoleChoices.OWNER
|
||||
).count()
|
||||
== 1
|
||||
):
|
||||
raise PermissionDenied("A resource should keep at least one owner.")
|
||||
return super().delete(*args, **kwargs)
|
||||
|
||||
|
||||
class Room(Resource):
|
||||
"""Model for one room"""
|
||||
|
||||
name = models.CharField(max_length=500)
|
||||
resource = models.OneToOneField(
|
||||
Resource,
|
||||
on_delete=models.CASCADE,
|
||||
parent_link=True,
|
||||
primary_key=True,
|
||||
)
|
||||
slug = models.SlugField(max_length=100, blank=True, null=True, unique=True)
|
||||
|
||||
configuration = models.JSONField(
|
||||
blank=True,
|
||||
default={},
|
||||
verbose_name=_("Visio room configuration"),
|
||||
help_text=_("Values for Visio parameters to configure the room."),
|
||||
)
|
||||
|
||||
class Meta:
|
||||
db_table = "impress_room"
|
||||
ordering = ("name",)
|
||||
verbose_name = _("Room")
|
||||
verbose_name_plural = _("Rooms")
|
||||
|
||||
def __str__(self):
|
||||
return capfirst(self.name)
|
||||
|
||||
def clean_fields(self, exclude=None):
|
||||
"""
|
||||
Automatically generate the slug from the name and make sure it does not look like a UUID.
|
||||
|
||||
We don't want any overlapping between the `slug` and the `id` fields because they can
|
||||
both be used to get a room detail view on the API.
|
||||
"""
|
||||
self.slug = slugify(self.name)
|
||||
try:
|
||||
uuid.UUID(self.slug)
|
||||
except ValueError:
|
||||
pass
|
||||
else:
|
||||
raise ValidationError({"name": f'Room name "{self.name:s}" is reserved.'})
|
||||
super().clean_fields(exclude=exclude)
|
||||
|
||||
Reference in New Issue
Block a user